-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename MontecarloRunner to MontecarloTransport #2317
Rename MontecarloRunner to MontecarloTransport #2317
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
@wkerzendorf @andrewfullard Please review this. |
Note that the tests are failing because they're testing the code changes against the old tardis-refdata. Ideally they should test the changes after this PR is merged. |
@@ -1,13 +1,15 @@ | |||
{ | |||
"cells": [ | |||
{ | |||
"attachments": {}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you know what this change is?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andrewfullard I'm not sure, Jupyter seems to have done it automatically on file save. (I just changed the occurrences of "runner" to "transport", didn't even run any cell.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's a new version of Jupyter notebook likely.
Codecov Report
@@ Coverage Diff @@
## master #2317 +/- ##
=======================================
Coverage 71.96% 71.96%
=======================================
Files 137 137
Lines 12514 12514
=======================================
Hits 9006 9006
Misses 3508 3508
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
📝 Description
Type: 🎢
infrastructure
This PR renames MontecarloRunner to MontecarloTransport (and all such mentions of runner, montecarlo_runner, etc).
It also updates the docs and .hdf files accordingly.
Note: This PR also needs the reference data to be updated, for which a PR is logged here.
Sibling Request
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docs
label