Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename MontecarloRunner to MontecarloTransport #68

Conversation

xansh
Copy link
Member

@xansh xansh commented Jun 9, 2023

📝 Description

Type: 🎢 infrastructure

Sibling Request

This PR supports the renaming of MontecarloRunner to MontecarloTransport (and all such mentions of runner, montecarlo_runner, etc)

🚦 Testing

How did you test these changes?

  • Testing pipeline
  • Other method (describe)
  • My changes can't be tested (explain why)

☑️ Checklist

  • I requested two reviewers for this pull request
  • I updated the documentation according to my changes
  • I built the documentation by applying the build_docs label

Note: If you are not allowed to perform any of these actions, ping (@) a contributor.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@xansh
Copy link
Member Author

xansh commented Jun 9, 2023

@wkerzendorf @andrewfullard Please also review this (this is a sibling request of tardis-sn/tardis#2317 )

@andrewfullard
Copy link
Contributor

To be clear, the data themselves haven't changed, just the name of the location within the HDF?

@xansh
Copy link
Member Author

xansh commented Jun 9, 2023

@andrewfullard Yes, only the key paths have changed from "simulation/runner/" to "simulation/transport/". The data is unchanged.

@andrewfullard andrewfullard self-requested a review June 9, 2023 17:19
@wkerzendorf wkerzendorf merged commit a45fae8 into tardis-sn:master Jun 9, 2023
@xansh xansh deleted the rename-MontecarloRunner-to-MontecarloTransport branch June 10, 2023 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants