Rename MontecarloRunner to MontecarloTransport #2310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
*beep* *bop* Hi, human. I'm the @tardis-bot and couldn't find your records in my database. I think we don't know each other, or you changed your credentials recently. Please add your name and email to In case you need to map an existing alias, follow this example. |
wkerzendorf
reviewed
Jun 8, 2023
| @@ -725,7 +725,7 @@ def runner_from_hdf(fname): | |||
| ) | |||
|
|
|||
| # Creating a runner object and storing data | |||
| new_runner = MontecarloRunner( | |||
| new_runner = MontecarloTransport( | |||
There was a problem hiding this comment.
let's rename new_runner into montecarlo_transport
wkerzendorf
reviewed
Jun 8, 2023
| @@ -97,7 +97,7 @@ class Simulation(PlasmaStateStorerMixin, HDFWriterMixin): | |||
| iterations : int | |||
| model : tardis.model.Radial1DModel | |||
| plasma : tardis.plasma.BasePlasma | |||
| runner : tardis.montecarlo.MontecarloRunner | |||
| montecarlo_transport : tardis.montecarlo.MontecarloRunner | |||
There was a problem hiding this comment.
that needs to be MonteCarloTransport right
|
@xansh tests fail |
xansh
changed the title
|
Accidentally closed this when I was renaming the branch. Logged a new request here. Please see that PR instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This request is stale. Please go to this PR instead.
📝 Description
Type: 🎢
restructureRefactored MontecarloRunner to MontecarloTransport and runner to montecarlo_transport for restructuring
🚦 Testing
How did you test these changes?
☑️ Checklist
build_docslabel