Raise an error when cannot parse identifier from title #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrew2net
approved these changes
Dec 18, 2022
ronaldtse
requested changes
Dec 19, 2022
| @@ -134,6 +134,8 @@ def self.parse_from_title(title) | |||
| # delete parts from the title until it's parseable | |||
| acc.reverse.sub(part.reverse, "").reverse.strip | |||
| end | |||
|
|
|||
| raise Errors::ParseError, "cannot parse #{title}" | |||
There was a problem hiding this comment.
Can we have more specific errors such as “InvalidPrefixError” (for disallowed prefixes), “InvalidTypedStageError” etc? Thanks.
There was a problem hiding this comment.
Can we have more specific errors such as “InvalidPrefixError” (for disallowed prefixes), “InvalidTypedStageError” etc? Thanks.
Parsing error is a result of Parslet's parsing error Parslet::ParseFailed, there are no way to extract the cause of error, only by reading long error message.
To get specific error, we need to change parsing and parse it step by step, could be quite challenging tasks because of many formats.
There was a problem hiding this comment.
Let's merge this first and then deal with more fine grained errors. Thanks.
ronaldtse
approved these changes
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #163