Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#parse_from_title returns an empty string #163

Closed
andrew2net opened this issue Nov 19, 2022 · 2 comments · Fixed by #175
Closed

#parse_from_title returns an empty string #163

andrew2net opened this issue Nov 19, 2022 · 2 comments · Fixed by #175
Assignees
@mico
Labels
bug Something isn't working

Comments

@andrew2net
Copy link 

> Pubid::Iso::Identifier.parse_from_title("ISO/IEC Guide 98-3:2008/Suppl 1:2008 Uncertainty of measurement — Part 3: Guide to the expression of uncertainty in measurement (GUM:1995) — Supplement 1: Propagation of distributions using a Monte Carlo method")
=> ""
@andrew2net andrew2net added the bug Something isn't working label Nov 19, 2022
@andrew2net andrew2net mentioned this issue Nov 19, 2022
Closed
@mico
Copy link
Contributor

mico commented Dec 18, 2022

It returns empty string because title is not parsable, we still don't support "Suppl" supplements (issue #153).
But maybe we should rise an error when title is not parsable.

@andrew2net
Copy link
Author

@mico yes, it should raise an error.

@andrew2net andrew2net reopened this Dec 18, 2022
@mico mico mentioned this issue Dec 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mico mico

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Raise an error when cannot parse identifier from title metanorma/pubid-iso
2 participants
@mico @andrew2net