chore(router): remove recon from default features #3370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kashif-m
force-pushed
the
default_recon
branch
from
df8eeae to
546f839
Compare
SanchithHegde
approved these changes
Jan 17, 2024
srujanchikke
approved these changes
Jan 17, 2024
pixincreate
added a commit
that referenced
this pull request
Jan 17, 2024
* 'main' of github.com:juspay/hyperswitch: refactor: [Noon] adding new field max_amount to mandate request (#3209) fix(events): fix event generation for paymentmethods list (#3337) chore(router): remove recon from default features (#3370) fix(core): add validation for authtype and metadata in update payment connector (#3305) refactor(connector): [cybersource] recurring mandate flow (#3354) feat(connector_events): added api to fetch connector event logs (#3319) feat(payment_method): add capability to store bank details using /payment_methods endpoint (#3113)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR disables the default
reconfeature and moves it to be a part ofreleaseinstead.Additional Changes
Motivation and Context
reconfeature is dependent onemailfeature which requires AWS SES credentials. This leads to application throwing an error / panic at application startup.How did you test it?
Tested locally using cargo hack -
cargo hack check --each-feature --no-dev-depsChecklist
cargo +nightly fmt --allcargo clippy