Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(payment_method): add capability to store bank details using /payment_methods endpoint #3113

Merged
merged 16 commits into from
Jan 17, 2024
Merged

feat(payment_method): add capability to store bank details using /payment_methods endpoint #3113

merged 16 commits into from
Jan 17, 2024

Conversation

kashif-m
Copy link
Contributor

@kashif-m kashif-m commented Dec 12, 2023 •
edited
Loading

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Ref - Issue #3112

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

How did you test it?

Tested locally

Postman collection - https://galactic-capsule-229427.postman.co/workspace/My-Workspace~2b563e0d-bad3-420f-8c0b-0fd5b278a4fe/collection/9906252-142ea0ea-f61f-48e7-8317-5f819dd535e9?action=share&creator=9906252

Test Cases
There are two major flows to be tested out which are fixed in this PR

  1. Check payouts operation works end to end (payout creation + payout fulfillment for bank / card)
    • Create a payout with auto_fulfill false
    • Fulfill this payout using /payout/fulfill API call
    • This ensures the intermediary data is being persisted in temp locker
  2. Payment methods saved for a customer can be used for any operation (payments / payouts) using payment_token
    • Create and fulfill a payout with recurring true against a cusomter_id
    • List SPMs for this customer
    • Using payment_token to carry out a payment or a payout transaction

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@kashif-m kashif-m added C-feature Category: Feature request or enhancement C-refactor Category: Refactor labels Dec 12, 2023
@kashif-m kashif-m self-assigned this Dec 12, 2023
@kashif-m kashif-m requested review from a team as code owners December 12, 2023 08:31
@github-actions github-actions bot added the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 12, 2023
@kashif-m kashif-m changed the title Bank wip feat(payment_method): add capability to store bank details using /payment_methods endpoint Dec 12, 2023
@github-actions github-actions bot removed the S-conventions-not-followed Status: This PR does not follow contributing guidelines label Dec 12, 2023
vspecky
vspecky requested changes Dec 15, 2023
View reviewed changes
@kashif-m kashif-m requested a review from vspecky December 19, 2023 04:56
@kashif-m kashif-m requested a review from Sarthak1799 December 19, 2023 04:56
NishantJoshi00
NishantJoshi00 previously approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@NishantJoshi00 NishantJoshi00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The request construction and and fields looks to be aligned with the locker schema

vspecky
vspecky previously approved these changes Jan 10, 2024
View reviewed changes
@kashif-m kashif-m dismissed stale reviews from vspecky and NishantJoshi00 via 74fe945 January 16, 2024 07:22
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 17, 2024
@likhinbopanna likhinbopanna removed this pull request from the merge queue due to a manual request Jan 17, 2024
@kashif-m kashif-m removed the request for review from NishantJoshi00 January 17, 2024 09:00
@pixincreate pixincreate added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 01c2de2 Jan 17, 2024
@pixincreate pixincreate deleted the bank_wip branch January 17, 2024 09:19
pixincreate added a commit that referenced this pull request Jan 17, 2024
@pixincreate
Merge branch 'main' of github.com:juspay/hyperswitch into env_split
1a23641 
* 'main' of github.com:juspay/hyperswitch:
  refactor: [Noon] adding new field max_amount to mandate request (#3209)
  fix(events): fix event generation for paymentmethods list (#3337)
  chore(router): remove recon from default features (#3370)
  fix(core): add validation for authtype and metadata in update payment connector (#3305)
  refactor(connector): [cybersource] recurring mandate flow (#3354)
  feat(connector_events): added api to fetch connector event logs (#3319)
  feat(payment_method): add capability to store bank details using /payment_methods endpoint (#3113)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sarthak1799 Sarthak1799 Sarthak1799 left review comments

@ArjunKarthik ArjunKarthik ArjunKarthik approved these changes

@vspecky vspecky vspecky approved these changes

@NishantJoshi00 NishantJoshi00 NishantJoshi00 left review comments

Assignees

@kashif-m kashif-m

Labels
C-feature Category: Feature request or enhancement C-refactor Category: Refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@kashif-m @ArjunKarthik @vspecky @NishantJoshi00 @Sarthak1799 @pixincreate @bernard-eugine