Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): add validation for authtype and metadata in update payment connector #3305

Merged
merged 5 commits into from
Jan 17, 2024

Conversation

srujanchikke
Copy link
Contributor

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Adding validation for authtype and metadata in update payment connector call.

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

Adding validation for authtype and metadata in update payment connector call.

How did you test it?

1)Try passing wrong metadata for any connector in update payment connector call

Screenshot 2024-01-10 at 3 51 20 PM

2)Try passing wrong authtype for any connector in update payment connector call
Screenshot 2024-01-10 at 3 51 52 PM

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@srujanchikke srujanchikke added A-core Area: Core flows C-bug Category: Bug S-waiting-on-review Status: This PR has been implemented and needs to be reviewed labels Jan 10, 2024
@srujanchikke srujanchikke self-assigned this Jan 10, 2024
@srujanchikke srujanchikke requested a review from a team as a code owner January 10, 2024 10:25
@srujanchikke srujanchikke linked an issue Jan 10, 2024 that may be closed by this pull request
2 tasks
Aprabhat19
Aprabhat19 previously approved these changes Jan 10, 2024
@likhinbopanna likhinbopanna added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 52f38d3 Jan 17, 2024
9 checks passed
@likhinbopanna likhinbopanna deleted the validate_authtype_in_update_connector branch January 17, 2024 10:23
pixincreate added a commit that referenced this pull request Jan 17, 2024
* 'main' of github.com:juspay/hyperswitch:
  refactor: [Noon] adding new field max_amount to mandate request (#3209)
  fix(events): fix event generation for paymentmethods list (#3337)
  chore(router): remove recon from default features (#3370)
  fix(core): add validation for authtype and metadata in update payment connector (#3305)
  refactor(connector): [cybersource] recurring mandate flow (#3354)
  feat(connector_events): added api to fetch connector event logs (#3319)
  feat(payment_method): add capability to store bank details using /payment_methods endpoint (#3113)
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core flows C-bug Category: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Validation for authtype and metadata in payment connector update
5 participants