-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add reusable workflow to create nightly tags in CalVer format #3247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShankarSinghC
previously approved these changes
Jan 5, 2024
pixincreate
previously approved these changes
Jan 5, 2024
de87a54
Chethan-rao
approved these changes
Jan 6, 2024
prajjwalkumar17
approved these changes
Jan 6, 2024
ShankarSinghC
approved these changes
Jan 8, 2024
12 tasks
pixincreate
added a commit
that referenced
this pull request
Jan 9, 2024
* 'main' of github.com:juspay/hyperswitch: feat(pm_list): add required fields for Ideal (#3183) refactor: pass customer object to `make_pm_data` (#3246) feat(Connector): [VOLT] Add support for Payments Webhooks (#3155) fix(users): Added merchant name is list merchants (#3289) fix(outgoingwebhookevents): Throw an error when outgoing webhook events env var not found (#3291) fix(wasm): fix failing `wasm-pack build` for `euclid_wasm` (#3284) ci: add workflow to create stable SemVer tag for a given CalVer tag (#3285) fix(connector): [BOA, Cybersource] capture error_code (#3239) fix(connector): [BOA/CYB] Fix Metadata Error (#3283) chore(version): 2024.01.08.0 fix: introduce net_amount field in payment response (#3115) ci(postman): Adyen assertion fix for expired card test case (#3279) feat(connector): Add Revoke mandate flow (#3261) refactor(drainer): change logic for trimming the stream and refactor for modularity (#3128) fix(router): Payment link api contract change (#2975) feat(pm_list): add required fields for eps (#3169) refactor(api_lock): allow api lock on psync only when force sync is true (#3242) fix(router): multiple incremental_authorizations with kv enabled (#3185) feat(payments): add payment id in all the payment logs (#3142) ci: add reusable workflow to create nightly tags in CalVer format (#3247)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
This PR adds a new reusable workflow to create tags in the calendar versioning (CalVer) format
YYYY.0M.0D.MICRO
(month and date are zero-padded, and theMICRO
version number starts from zero) instead of the existingrelease-new-version
workflow to create SemVer tags. The workflow uses a GitHub app token and GitHub API calls to commit the changes and tag them in order to have verified commits and tags.The reusable workflow can be used like so (provided the secrets have been set up):
Refer to the docs for more information.
Prerequisites for using the reusable workflow
git-cliff
configuration file located at.github/git-cliff-changelog.toml
.Motivation and Context
We will be using CalVer tags for daily tags, which will be used internally for testing, and SemVer tags for stable releases which are meant to be used by end users.
How did you test it?
I temporarily updated the workflow file to run on this branch, the commits in this PR include the commits pushed by the bot. Note that the commits created by the bot are also signed.
One of the action runs: https://github.com/juspay/hyperswitch/actions/runs/7401505144
As a proof of the tag that was created by the bot, I'm including a screenshot of the tag that was pushed (which was since deleted). Note that the tag created is also signed.
The
2024.01.03-test-tag
had to be created manually by me because the workflow does not handle that case.Checklist
cargo +nightly fmt --all
cargo clippy