Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connector): [BOA, Cybersource] capture error_code #3239

Merged
merged 20 commits into from
Jan 9, 2024

Conversation

AkshayaFoiger
Copy link
Contributor

@AkshayaFoiger AkshayaFoiger commented Jan 4, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

Resolves #3739

How did you test it?

1.Create a failed payment using Cybersource, ensuring that the error_code includes the specific error reason (connector response must include error.reason)

Screenshot 2024-01-04 at 1 48 12 PM

3.Create a failed payment with BOA, ensuring that the error_code includes the specific error reason (connector response must include error.reason)

Screenshot 2024-01-04 at 1 47 44 PM

Test Case

Failed card number for both connectors: 412345678912345678914
1.Create a failed payment using Cybersource, ensuring that the error_code includes the specific error reason (connector response must include error.reason)
2.Create a failed refund using Cybersource, ensuring that the error_code includes the specific error reason (connector response must include error.reason)
3.Create a failed payment using BOA, ensuring that the error_code includes the specific error reason (connector response must include error.reason)
4.Create a failed refund using BOA, ensuring that the error_code includes the specific error reason (connector response must include error.reason)

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible
  • I added a CHANGELOG entry if applicable

@AkshayaFoiger AkshayaFoiger requested a review from a team as a code owner January 4, 2024 08:33
@AkshayaFoiger AkshayaFoiger self-assigned this Jan 4, 2024
@AkshayaFoiger AkshayaFoiger added A-connector-compatibility Area: Connector compatibility A-connector-integration Area: Connector integration C-refactor Category: Refactor labels Jan 4, 2024
@AkshayaFoiger AkshayaFoiger added the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 4, 2024
ArjunKarthik
ArjunKarthik previously approved these changes Jan 5, 2024
ArjunKarthik
ArjunKarthik previously approved these changes Jan 5, 2024
srujanchikke
srujanchikke previously approved these changes Jan 8, 2024
@Gnanasundari24 Gnanasundari24 added this pull request to the merge queue Jan 9, 2024
Merged via the queue into main with commit ecf51b5 Jan 9, 2024
@Gnanasundari24 Gnanasundari24 deleted the Error-Code-handling-BOA-CC branch January 9, 2024 07:15
pixincreate added a commit that referenced this pull request Jan 9, 2024
* 'main' of github.com:juspay/hyperswitch:
  feat(pm_list): add required fields for Ideal  (#3183)
  refactor: pass customer object to `make_pm_data` (#3246)
  feat(Connector): [VOLT] Add support for Payments Webhooks (#3155)
  fix(users): Added merchant name is list merchants (#3289)
  fix(outgoingwebhookevents): Throw an error when outgoing webhook events env var not found (#3291)
  fix(wasm): fix failing `wasm-pack build` for `euclid_wasm` (#3284)
  ci: add workflow to create stable SemVer tag for a given CalVer tag (#3285)
  fix(connector): [BOA, Cybersource] capture error_code (#3239)
  fix(connector): [BOA/CYB] Fix Metadata Error (#3283)
  chore(version): 2024.01.08.0
  fix: introduce net_amount field in payment response (#3115)
  ci(postman): Adyen assertion fix for expired card test case  (#3279)
  feat(connector): Add Revoke mandate flow (#3261)
  refactor(drainer): change logic for trimming the stream and refactor for modularity (#3128)
  fix(router): Payment link api contract change (#2975)
  feat(pm_list): add required fields for eps (#3169)
  refactor(api_lock): allow api lock on psync only when force sync is true (#3242)
  fix(router): multiple incremental_authorizations with kv enabled (#3185)
  feat(payments): add payment id in all the payment logs (#3142)
  ci: add reusable workflow to create nightly tags in CalVer format (#3247)
@SanchithHegde SanchithHegde removed the S-waiting-on-review Status: This PR has been implemented and needs to be reviewed label Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-connector-compatibility Area: Connector compatibility A-connector-integration Area: Connector integration C-refactor Category: Refactor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants