refactor(drainer): change logic for trimming the stream and refactor for modularity #3128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dracarys18
added
A-framework
akshay-97
previously approved these changes
Dec 13, 2023
jarnura
requested changes
Dec 14, 2023
jarnura
previously approved these changes
Dec 15, 2023
akshay-97
previously approved these changes
Dec 15, 2023
akshay-97
approved these changes
Jan 8, 2024
jarnura
approved these changes
Jan 8, 2024
pixincreate
added a commit
that referenced
this pull request
Jan 9, 2024
* 'main' of github.com:juspay/hyperswitch: feat(pm_list): add required fields for Ideal (#3183) refactor: pass customer object to `make_pm_data` (#3246) feat(Connector): [VOLT] Add support for Payments Webhooks (#3155) fix(users): Added merchant name is list merchants (#3289) fix(outgoingwebhookevents): Throw an error when outgoing webhook events env var not found (#3291) fix(wasm): fix failing `wasm-pack build` for `euclid_wasm` (#3284) ci: add workflow to create stable SemVer tag for a given CalVer tag (#3285) fix(connector): [BOA, Cybersource] capture error_code (#3239) fix(connector): [BOA/CYB] Fix Metadata Error (#3283) chore(version): 2024.01.08.0 fix: introduce net_amount field in payment response (#3115) ci(postman): Adyen assertion fix for expired card test case (#3279) feat(connector): Add Revoke mandate flow (#3261) refactor(drainer): change logic for trimming the stream and refactor for modularity (#3128) fix(router): Payment link api contract change (#2975) feat(pm_list): add required fields for eps (#3169) refactor(api_lock): allow api lock on psync only when force sync is true (#3242) fix(router): multiple incremental_authorizations with kv enabled (#3185) feat(payments): add payment id in all the payment logs (#3142) ci: add reusable workflow to create nightly tags in CalVer format (#3247)
SanchithHegde
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Refactored drainer for modularity and maintainability and changed the logic for trimming the stream.
Motivation and Context
Currently we are trimming the data from the stream regardless of deserialization error or errors while executing the query. This will cause serious data loss in case if we had any error during the query execution or deserialization. So trim only until the last successful ID that was processed.
Also refactored drainer for modularity and maintainability.
How did you test it?
Checklist
cargo +nightly fmt --allcargo clippy