Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the Note toolbar plugin #169

Closed
FeralFlora opened this issue May 22, 2024 · 4 comments
Closed

Add support for the Note toolbar plugin #169

FeralFlora opened this issue May 22, 2024 · 4 comments
Assignees
Labels
Feature Request Enhancement and/or Feature suggestion

Comments

@FeralFlora
Copy link

FeralFlora commented May 22, 2024

Is your feature request related to a problem? Please describe.
I was looking to try out the Note toolbar plugin, but got stuck trying to make the toolbars look nicer, because it was looking really strange (see image). Then, after switching to the default theme, I realized that it was a theme issue.

Here's what a note toolbar looks like when using Prism:

image

Here's the settings I've applied when configuring the note toolbar (refer to the plugin docs to see what each option ought to do:
https://github.com/chrisgurney/obsidian-note-toolbar/wiki/Styling-toolbars#how-styles-are-applied).

image

As you can see, the Note toolbar shouldn't have a border, according to my settings, and each item should be styled as a button.

Describe the solution you'd like
I would like for the note toolbar to be styled correctly while using the Prism theme. Correctly meaning that the style settings set in the Note toolbar's settings actually apply. As they do here with the default theme:

image

Describe alternatives you've considered
Making this request in the Note toolbar repo instead. Sorry if this request is misplaced. However, as you can see below, Prism seems to be the theme that deviates the furthest from the expected styling.

Additional context
Note toolbar styling with some other themes:

Polka

image

(note toolbar border is the same as the one applied to callouts)

Aura

image

Minimal

image

AnuPpuccin

image

Border

image

MagicUser

image

@FeralFlora FeralFlora added the Feature Request Enhancement and/or Feature suggestion label May 22, 2024
@damiankorcz
Copy link
Owner

Hi @FeralFlora,
This should be resolved in an upcoming update. I'll close this issue and let you know when it's out. Not entirely sure why the plugin dev decided to use Callout styling CSS classes for this toolbar, it's what caused the border since my changes to callouts were applying to it. Had to specifically exclude them from this plugin.

@FeralFlora
Copy link
Author

This should be resolved in an upcoming update.

Nice, thank you!

Not entirely sure why the plugin dev decided to use Callout styling CSS classes for this toolbar

Yeah, I don't know either. Perhaps it has something to do with the plugins other ability to render actual callouts as toolbars, and consistency in this regard? https://github.com/chrisgurney/obsidian-note-toolbar/wiki/Note-Toolbar-Callouts

@damiankorcz
Copy link
Owner

Hi @FeralFlora,
This should now be addressed in Prism 3.5.3. Note that the release requires Obsidian app version 1.6.0 or above.

@chrisgurney
Copy link

@damiankorcz Thanks so much for accommodating my plugin in your theme.

Per @FeralFlora I used callout CSS for the toolbar so that the Note Toolbar callouts capability works. (The plugin originally started as just a CSS snippet.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Enhancement and/or Feature suggestion
Projects
None yet
Development

No branches or pull requests

3 participants