Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass to afterPersist hook the attributes from beforeInstantiate #745

Merged
merged 2 commits into from
Dec 14, 2024
Merged

fix: pass to afterPersist hook the attributes from beforeInstantiate #745

merged 2 commits into from
Dec 14, 2024

Conversation

nikophil
Copy link
Member

@nikophil nikophil commented Dec 12, 2024 •
edited
Loading

@nikophil nikophil changed the title bug/before instantiate attribute fix: Attributes added in beforeInstantiate are not passed to afterPersist Dec 12, 2024
@nikophil nikophil mentioned this pull request Dec 12, 2024
Closed
@nikophil nikophil requested a review from kbond December 12, 2024 16:57
@nikophil nikophil changed the title fix: Attributes added in beforeInstantiate are not passed to afterPersist fix: pass to afterPersist hook the attributes from beforeInstantiate Dec 13, 2024
kbond
kbond approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@kbond kbond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@nikophil nikophil merged commit ea89504 into zenstruck:2.x Dec 14, 2024
54 checks passed
@nikophil nikophil deleted the bug/before-instantiate-attribute branch December 14, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbond kbond kbond approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikophil @kbond