fix(2.x): add back second parameter for after persist callbacks #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
commented
Jun 11, 2024
| if ($this->afterPersist) { | ||
| $attributes = $this->normalizeAttributes($attributes); |
There was a problem hiding this comment.
not a huge fan of this:
- this is already done in
parent::create() - we won't pass attributes added in
beforeInstantiatecallbacks
any thought @kbond ?
There was a problem hiding this comment.
Hmm, I agree, this doesn't feel great. I guess I totally missed this part when working on 2.0...
nikophil
force-pushed
the
fix/add-after-persit-second-attribute
branch
from
52b080d to
1b37e1d
Compare
nikophil
commented
Jun 11, 2024
| @@ -562,14 +562,6 @@ they were added. | |||
| // $object is the instantiated object | |||
| // $attributes contains the attributes used to instantiate the object and any extras | |||
| }) | |||
| ->afterPersist(function(Proxy $proxy, array $attributes) { | |||
There was a problem hiding this comment.
we're not doing this anymore... This is a BC break between 1.x and 2.x 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #628