Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make DEFAULT_EVENTS_PER_MAILBOX unreachable (#14843)" #15488

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

naspirato
Copy link
Collaborator

@naspirato naspirato commented Mar 9, 2025

Changelog entry

To fix perfomance regression in stable-25-1
#15185 (comment)

Result after revert

cluster_monitoring repository git_branch run_type run_start_datetime git_sha git_commit_timestamp duration sec warehouses tpmC efficiency newOrder90p
monium ydb-platform/ydb origin/main 25_1_1_and_main_revert_14843 09.03.2025 21:51:44 926459d 08.03.2025 20:13:18 7200 16000 🟢 204806 99.54 🟢 112

Before revert

cluster_monitoring repository git_branch run_type run_start_datetime git_sha git_commit_timestamp duration sec warehouses tpmC efficiency newOrder90p
monium ydb-platform/ydb origin/main EnableLocalDBBtreeIndex-false 08.03.2025 02:08:37 2b1cfa7 20.02.2025 18:07:12 10800 16000 🔴 201910 98.13 🔴 750

Reverts #14843

Changelog category

  • Bugfix
  • Performance

Description for reviewers

...

Copy link

github-actions bot commented Mar 9, 2025

🔴 2025-03-09 21:43:26 UTC The validation of the Pull Request description has failed. Please update the description.

Only one category can be selected at a time.

Copy link

github-actions bot commented Mar 9, 2025

2025-03-09 12:41:41 UTC Pre-commit check linux-x86_64-release-asan for 7d0d421 has started.
2025-03-09 12:41:56 UTC Artifacts will be uploaded here
2025-03-09 12:45:06 UTC ya make is running...
🟡 2025-03-09 14:31:59 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14076 13920 0 92 26 38

2025-03-09 14:33:14 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-09 14:49:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
221 (only retried tests) 178 0 8 3 32

2025-03-09 14:49:39 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-09 15:01:28 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
77 (only retried tests) 44 0 1 3 29

🟢 2025-03-09 15:01:36 UTC Build successful.
🟢 2025-03-09 15:02:09 UTC ydbd size 3.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: cc84759 merge: 7d0d421 diff diff %
ydbd size 3 996 545 000 Bytes 3 996 544 904 Bytes -96 Bytes -0.000%
ydbd stripped size 1 389 195 176 Bytes 1 389 195 112 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link

github-actions bot commented Mar 9, 2025

2025-03-09 12:42:04 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7d0d421 has started.
2025-03-09 12:42:08 UTC Artifacts will be uploaded here
2025-03-09 12:45:13 UTC ya make is running...
🟡 2025-03-09 14:13:04 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28551 25959 0 1 2473 118

2025-03-09 14:15:31 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-09 14:26:41 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
174 (only retried tests) 68 0 0 0 106

🟢 2025-03-09 14:26:48 UTC Build successful.
🟢 2025-03-09 14:27:06 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: cc84759 merge: 7d0d421 diff diff %
ydbd size 2 294 860 176 Bytes 2 294 860 176 Bytes 0 Bytes 0.000%
ydbd stripped size 480 611 392 Bytes 480 611 392 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions github-actions bot added the bugfix label Mar 9, 2025
@naspirato naspirato changed the title Revert "Make DEFAULT_EVENTS_PER_MAILBOX unreachable" Revert "Make DEFAULT_EVENTS_PER_MAILBOX unreachable" (#14843) Mar 9, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 9, 2025
@naspirato naspirato changed the title Revert "Make DEFAULT_EVENTS_PER_MAILBOX unreachable" (#14843) Revert "Make DEFAULT_EVENTS_PER_MAILBOX unreachable (#14843)" Mar 9, 2025
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 9, 2025
@naspirato naspirato requested a review from kruall March 9, 2025 21:34
@github-actions github-actions bot added bugfix and removed bugfix labels Mar 9, 2025
@naspirato naspirato requested a review from maximyurchuk March 9, 2025 21:43
@naspirato naspirato marked this pull request as ready for review March 9, 2025 21:43
Copy link

github-actions bot commented Mar 9, 2025

2025-03-09 21:46:07 UTC Pre-commit check linux-x86_64-relwithdebinfo for 7d0d421 has started.
2025-03-09 21:46:22 UTC Artifacts will be uploaded here
2025-03-09 21:49:32 UTC ya make is running...
🟡 2025-03-09 22:45:11 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
28549 25950 0 2 2480 117

2025-03-09 22:47:29 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-03-09 23:01:34 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
178 (only retried tests) 74 0 0 0 104

🟢 2025-03-09 23:01:44 UTC Build successful.
🟢 2025-03-09 23:02:01 UTC ydbd size 2.1 GiB changed* by 0 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: cc84759 merge: 7d0d421 diff diff %
ydbd size 2 294 860 176 Bytes 2 294 860 176 Bytes 0 Bytes 0.000%
ydbd stripped size 480 611 392 Bytes 480 611 392 Bytes 0 Bytes 0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Copy link
Collaborator

@maximyurchuk maximyurchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это надо будет черрипикнуть в
stable-25-1
stable-25-1-1

И я бы подождал еще ока от @kruall

Copy link

github-actions bot commented Mar 9, 2025

2025-03-09 21:46:28 UTC Pre-commit check linux-x86_64-release-asan for 7d0d421 has started.
2025-03-09 21:46:43 UTC Artifacts will be uploaded here
2025-03-09 21:50:00 UTC ya make is running...
🟡 2025-03-09 23:02:20 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
14076 13795 0 222 24 35

2025-03-09 23:03:31 UTC ya make is running... (failed tests rerun, try 2)
🟡 2025-03-09 23:19:31 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
362 (only retried tests) 322 0 5 2 33

2025-03-09 23:19:40 UTC ya make is running... (failed tests rerun, try 3)
🟡 2025-03-09 23:31:30 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet

Test history | Ya make output | Test bloat | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
73 (only retried tests) 41 0 1 0 31

🟢 2025-03-09 23:31:37 UTC Build successful.
🟢 2025-03-09 23:32:08 UTC ydbd size 3.7 GiB changed* by -96 Bytes, which is <= 0 Bytes vs main: OK

ydbd size dash main: cc84759 merge: 7d0d421 diff diff %
ydbd size 3 996 545 000 Bytes 3 996 544 904 Bytes -96 Bytes -0.000%
ydbd stripped size 1 389 195 176 Bytes 1 389 195 112 Bytes -64 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants