Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TPCC latency regression: stable-25-1 with EnableLocalDBBtreeIndex-false #15185

Open
naspirato opened this issue Feb 28, 2025 · 6 comments
Open
Assignees

Comments

@naspirato
Copy link
Collaborator

naspirato commented Feb 28, 2025

Regression in 2b1cfa7
@kunga, @kruall, what we shoud do next?

Result of TPCC in revert vs commit

2b1cfa7 => in my repo 2b1cfa7
🔴 perf 4 4h 90p=508 ms https://nda.ya.ru/t/wYxtayFC7CbYAy

revert of 2b1cfa7 in my repo 926459d
🟢 perf 4 4h 90p=112ms https://nda.ya.ru/t/tAN3Uj3r7CbYDr


branch timestamp git_commit_timestamp git_sha tpmC newOrderLatency90 reason
stable-25-1 27.02.2025 21:52:14 27.02.2025 13:58:56 d0aa06b 🔴203449 🔴508 ?
stable-25-1 27.02.2025 06:40:48 26.02.2025 14:12:05 79eee97 🟢204346 🔴220 ?
stable-25-1 26.02.2025 23:22:23 26.02.2025 14:12:05 79eee97 🔴203304 🔴508 ?
stable-25-1 26.02.2025 06:42:07 25.02.2025 12:56:37 abfc4e2 🔴203181 🔴750 ?
stable-25-1 25.02.2025 14:22:19 25.02.2025 09:09:54 09bfb76 🔴202196 🔴1000 ?
stable-25-1 24.02.2025 22:47:40 24.02.2025 12:55:29 68d3b5a 🟢204260 🔴208 ?
stable-25-1 24.02.2025 08:01:55 24.02.2025 02:51:21 f510f6f 🟢204570 🟠136 ?
stable-25-1 24.02.2025 00:13:12 23.02.2025 15:24:23 6e0cee5 🟢204057 🔴 460 ?
stable-25-1 23.02.2025 09:31:09 21.02.2025 18:00:21 e9a49fa 🟢204650 🟢 112 🟢ok
stable-25-1 22.02.2025 02:02:56 21.02.2025 18:00:21 e9a49fa 🟢204883 🟢 100 🟢ok
@naspirato
Copy link
Collaborator Author

naspirato commented Mar 1, 2025

run_type run_start_datetime git_sha git_commit_timestamp tpmC latency 90p
EnableLocalDBBtreeIndex-true 28.02.2025 17:59:13 34500f4 28.02.2025 12:08:06 🟢204603 🟢124
EnableLocalDBBtreeIndex-false 01.03.2025 15:58:54 14dd0b0 28.02.2025 09:37:34 🔴202899 🔴750

good EnableLocalDBBtreeIndex-true
Image

monium https://nda.ya.ru/t/PV86NBsg7CNssb

bad EnableLocalDBBtreeIndex-false
Image

monium https://nda.ya.ru/t/f4rv8W797CNstQ

@kunga kunga self-assigned this Mar 3, 2025
@kunga
Copy link
Member

kunga commented Mar 3, 2025

Perhaps the bug was added somewhere around #12198 / #8447

@naspirato
Copy link
Collaborator Author

naspirato commented Mar 4, 2025

21.02.2025 12:58:40 4ca0181 - 🔴
https://nda.ya.ru/t/qi447Cqt7CTSH5

68ccd29 - Fri Feb 21 08:33:08 2025 +0100 changes for FSTEC certification (#14878) Alexey Efimov 🔴
https://nda.ya.ru/t/PXRCaUQB7CV8aN


perf4 на 4 часа

a8fbe60 - Fri Feb 21 10:03:48 2025 +0300 Identify node_type in actor system's auto config (#14799) kruall 🔴
🔴perf3 p90 = 508ms -> revert нельзя сделать
https://nda.ya.ru/t/HuNTN-Lj7CWYvH

3fb5075 - Fri Feb 21 07:49:03 2025 +0100 correctly handle inf values in streaming query (#14875) Alexey Efimov 🔴
🟠 perf3 p90 = 208ms https://nda.ya.ru/t/lXFKmk-Z7CYGzn
🔴perf4 4h p90= 508ms https://nda.ya.ru/t/kiV-w42B7CYGws
perf3 3h revert in progress

9659d35 - Fri Feb 21 00:51:46 2025 +0000 Import libraries 250221-0050 Alexander Smirnov 🔴
🔴perf4 4h p90= 508ms https://nda.ya.ru/t/G5WGrsv_7CYWUB

7c09b27 - Fri Feb 21 00:51:45 2025 +0000 Merge branch 'rightlib' into merge-libs-250221-0050 Alexander Smirnov


perf5 на 4 часа

555fbb8 - Thu Feb 20 23:01:41 2025 +0300 Fix distconf configuration fetch machinery (#14864) Alexander Rutkovsky 🟢
🟢 perf5 4h p90=90ms https://nda.ya.ru/t/NSeqv98d7CYHk6

23aa667 - Thu Feb 20 22:35:38 2025 +0300 BATCH UPDATE/DELETE queries for per row updates with NoTx (#13340) Daniil Timizhev 🟠
🟠 perf3 p90 = 184ms https://nda.ya.ru/t/bqRm-17q7CVcUv ;
🟠 perf5 p90=124ms https://nda.ya.ru/t/_HbiQuXo7CZ6om

2b1cfa7 - Thu Feb 20 21:07:12 2025 +0300 Make DEFAULT_EVENTS_PER_MAILBOX unreachable (#14843) kruall 🟢


91bc1bd - Thu Feb 20 19:49:35 2025 +0300 EvWrite: Fix status (UNAVAILABLE -> UNDETERMINED) (#14839) Nikita Vasilev perf5 🟢 perf5 p90 = 90ms dash
https://nda.ya.ru/t/AhKxGx7o7CX3MN

3ee5135 - Thu Feb 20 17:44:51 2025 +0500 YQ-3561 add features for FQ-run (#14826) Pisarenko Grigoriy 🟢
https://nda.ya.ru/t/3uhx8wDW7CUmxo

85359f5 - Wed Feb 19 10:29:14 2025 +0300 store all versions of TTL in memory (#14677) Semyon 🟢

31aa280 - Mon Feb 17 17:56:07 2025 +0300 Fix bug with permission in validate_pr_description (#14667) Natasha Pirogova

92e49da - Fri Feb 14 23:11:42 2025 +0300 take ownership for ut/olap (#14595) zverevgeny 🟢 https://nda.ya.ru/t/A9yAZzgs7CU6u2

10.02.2025 00:51:35 a6ef48e - 🟢
https://nda.ya.ru/t/wYikAf687CTSEv

git log --graph --oneline --pretty=format:'%H - %ad %s %an' --first-parent a6ef48e773c792ab7bb05bc137a014844d71728a\^..4ca01816efdd3d939ebf7e336ba0f6637d286216
git log --graph --oneline --pretty=format:'%H - %ad %s %an' --first-parent 555fbb8^..9659d35
https://nda.ya.ru/t/OsshCqF-7CTRCY

@naspirato
Copy link
Collaborator Author

naspirato commented Mar 7, 2025

https://datalens.yandex.cloud/2ohtijbghz3cq-tpc-c-debug?state=ebbe01ea708

git log --graph --oneline --pretty=format:'%H - %ad %s %an' --first-parent  555fbb84960c627348a33fe3d0594eec72d6216f\^..9659d35bdde68d6f5c9fda24f8249509a9ea2e60

@naspirato
Copy link
Collaborator Author

git log --graph --oneline --pretty=format:'%H - %ad %s %an' fa3d243d1431ecae6b77b2de955396627d675293

@naspirato
Copy link
Collaborator Author

naspirato commented Mar 8, 2025

2b1cfa7 => in my repo 2b1cfa7
🔴 perf 4 4h 90p=508 ms https://nda.ya.ru/t/wYxtayFC7CbYAy

revert of 2b1cfa7 in my repo 926459d
🟢 perf 4 4h 90p=112ms https://nda.ya.ru/t/tAN3Uj3r7CbYDr

@naspirato naspirato changed the title TPCC latency regression: stable-25-1 TPCC latency regression: stable-25-1 with EnableLocalDBBtreeIndex-false Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants