Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Identify node_type in actor system's auto config #14799

Merged
merged 4 commits into from
Feb 21, 2025
Merged

Identify node_type in actor system's auto config #14799

merged 4 commits into from
Feb 21, 2025

Conversation

kruall
Copy link
Collaborator

@kruall kruall commented Feb 19, 2025

Changelog entry

ydbd identifies node type when node_type not assign in actor_system_config

Changelog category

  • Improvement

Description for reviewers

...

@kruall kruall added the area/actorsystem Actor System related issues label Feb 19, 2025
@kruall kruall requested a review from alexvru February 19, 2025 14:23
@github-actions GitHub Actions
Copy link

🟢 2025-02-19 14:24:26 UTC The validation of the Pull Request description is successful.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

⚪ 2025-02-19 14:25:28 UTC Pre-commit check linux-x86_64-release-asan for a37d721 has started.
⚪ 2025-02-19 14:25:59 UTC Artifacts will be uploaded here
⚪ 2025-02-19 14:29:26 UTC ya make is running...
🔴 2025-02-19 14:35:48 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 19, 2025 •
edited
Loading

⚪ 2025-02-19 14:25:38 UTC Pre-commit check linux-x86_64-relwithdebinfo for a37d721 has started.
⚪ 2025-02-19 14:25:51 UTC Artifacts will be uploaded here
⚪ 2025-02-19 14:28:35 UTC ya make is running...
🔴 2025-02-19 14:41:41 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 11:45:16 UTC Pre-commit check linux-x86_64-relwithdebinfo for ca8bdb1 has started.
⚪ 2025-02-20 11:45:29 UTC Artifacts will be uploaded here
⚪ 2025-02-20 11:48:18 UTC ya make is running...
🟢 2025-02-20 13:16:37 UTC ydbd size 2.1 GiB changed* by +8.6 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 4a69e43 merge: ca8bdb1 diff diff %
ydbd size 2 239 403 032 Bytes 2 239 411 808 Bytes +8.6 KiB +0.000%
ydbd stripped size 474 529 336 Bytes 474 529 656 Bytes +320 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation
⚫ 2025-02-20 13:16:39 UTC Check cancelled

@github-actions GitHub Actions
Copy link

⚪ 2025-02-20 11:46:19 UTC Pre-commit check linux-x86_64-release-asan for ca8bdb1 has started.

@kruall kruall added the rebase-and-check Rebase PR with the current base branch and check label Feb 20, 2025
@github-actions github-actions bot removed the rebase-and-check Rebase PR with the current base branch and check label Feb 20, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 13:17:44 UTC Pre-commit check linux-x86_64-release-asan for 0986bdb has started.
⚪ 2025-02-20 13:17:50 UTC Artifacts will be uploaded here
⚪ 2025-02-20 13:20:45 UTC ya make is running...
🟡 2025-02-20 14:36:05 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13438 13344 0 49 9 36

⚪ 2025-02-20 14:37:23 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 14:49:52 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
142 (only retried tests) 104 0 0 3 35

🟢 2025-02-20 14:50:00 UTC Build successful.
🟢 2025-02-20 14:50:31 UTC ydbd size 3.6 GiB changed* by +928 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3ee5135 merge: 0986bdb diff diff %
ydbd size 3 895 673 176 Bytes 3 895 674 104 Bytes +928 Bytes +0.000%
ydbd stripped size 1 364 069 600 Bytes 1 364 070 048 Bytes +448 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 13:18:12 UTC Pre-commit check linux-x86_64-relwithdebinfo for 0986bdb has started.
⚪ 2025-02-20 13:19:11 UTC Artifacts will be uploaded here
⚪ 2025-02-20 13:22:03 UTC ya make is running...
🟡 2025-02-20 14:34:38 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20758 19408 0 1 1213 136

⚪ 2025-02-20 14:36:32 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 14:48:53 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
202 (only retried tests) 74 0 0 1 127

🟢 2025-02-20 14:49:01 UTC Build successful.
🟢 2025-02-20 14:49:20 UTC ydbd size 2.1 GiB changed* by +608 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 3ee5135 merge: 0986bdb diff diff %
ydbd size 2 239 511 352 Bytes 2 239 511 960 Bytes +608 Bytes +0.000%
ydbd stripped size 474 551 896 Bytes 474 552 024 Bytes +128 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 15:35:20 UTC Pre-commit check linux-x86_64-relwithdebinfo for 2b2e91d has started.
⚪ 2025-02-20 15:45:18 UTC Artifacts will be uploaded here
⚪ 2025-02-20 15:48:06 UTC ya make is running...
🔴 2025-02-20 16:00:15 UTC Build failed, see the logs. Also see fail summary

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 15:35:28 UTC Pre-commit check linux-x86_64-release-asan for 2b2e91d has started.
⚪ 2025-02-20 15:37:14 UTC Artifacts will be uploaded here
⚪ 2025-02-20 15:40:11 UTC ya make is running...
🔴 2025-02-20 15:50:40 UTC Build failed, see the logs. Also see fail summary

alexvru
alexvru previously approved these changes Feb 20, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 16:23:15 UTC Pre-commit check linux-x86_64-release-asan for 131d58b has started.
⚪ 2025-02-20 16:23:33 UTC Artifacts will be uploaded here
⚪ 2025-02-20 16:26:24 UTC ya make is running...
🟡 2025-02-20 17:28:46 UTC Some tests failed, follow the links below. This fail is not in blocking policy yet Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
13438 13338 0 50 17 33

⚪ 2025-02-20 17:30:49 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 17:42:58 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
145 (only retried tests) 113 0 0 4 28

🟢 2025-02-20 17:43:06 UTC Build successful.
🟢 2025-02-20 17:43:30 UTC ydbd size 3.6 GiB changed* by +688 Bytes, which is < 100.0 KiB vs main: OK

ydbd size dash main: 2d2ec59 merge: 131d58b diff diff %
ydbd size 3 895 664 984 Bytes 3 895 665 672 Bytes +688 Bytes +0.000%
ydbd stripped size 1 364 067 552 Bytes 1 364 067 808 Bytes +256 Bytes +0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

⚪ 2025-02-20 16:25:05 UTC Pre-commit check linux-x86_64-relwithdebinfo for 131d58b has started.
⚪ 2025-02-20 16:25:37 UTC Artifacts will be uploaded here
⚪ 2025-02-20 16:28:26 UTC ya make is running...
🟡 2025-02-20 17:19:58 UTC Some tests failed, follow the links below. Going to retry failed tests...

Test history | Ya make output | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
20758 19403 0 4 1218 133

⚪ 2025-02-20 17:22:45 UTC ya make is running... (failed tests rerun, try 2)
🟢 2025-02-20 17:41:36 UTC Tests successful.

Test history | Ya make output | Test bloat | Test bloat

TESTS PASSED ERRORS FAILED SKIPPED MUTED?
209 (only retried tests) 80 0 0 3 126

🟢 2025-02-20 17:41:44 UTC Build successful.
🟢 2025-02-20 17:42:05 UTC ydbd size 2.1 GiB changed* by +1.1 KiB, which is < 100.0 KiB vs main: OK

ydbd size dash main: 8f7f05b merge: 131d58b diff diff %
ydbd size 2 239 506 072 Bytes 2 239 507 216 Bytes +1.1 KiB +0.000%
ydbd stripped size 474 551 000 Bytes 474 550 872 Bytes -128 Bytes -0.000%

*please be aware that the difference is based on comparing your commit and the last completed build from the post-commit, check comparation

@kruall kruall enabled auto-merge (squash) February 21, 2025 06:59
@kruall kruall merged commit a8fbe60 into ydb-platform:main Feb 21, 2025
12 checks passed
This was referenced Feb 21, 2025
Closed
Merged
@serbel324 serbel324 mentioned this pull request Feb 25, 2025
Merged
lberserq pushed a commit to lberserq/ydb that referenced this pull request Mar 3, 2025
@kruall
Identify node_type in actor system's auto config (ydb-platform#14799)
8a6db62
@GrigoriyPA GrigoriyPA mentioned this pull request Mar 4, 2025
Open
@naspirato naspirato mentioned this pull request Mar 5, 2025
Open
@serbel324 serbel324 mentioned this pull request Mar 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexvru alexvru alexvru approved these changes

Assignees
No one assigned
Labels
area/actorsystem Actor System related issues improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kruall @alexvru