Add support to measure status_codes #317
Conversation
|
@wpjunior Thanks contribute. Unfortunately, the status dash board(html page) seems to corrupt the series of N/A appered suddenly in server zone. Note that the page is used by many users now a day, they will suprise what happened when the feature turn on. |
…rometheus displays
|
Hi @u5surf, I extracted the status codes into a separate JSON structure, so the status page is still working as before. I believe I have finished the merge request. |
There was a problem hiding this comment.
@wpjunior
Hi, Could you handling following control command?
https://github.com/vozlt/nginx-module-vts?tab=readme-ov-file#to-reset-traffic-zones-on-the-fly
The status 1xx - 5xx can be reset by this command on the fly.
We should make a consistent with this behavior.
|
Hi @u5surf I implemented this feature :-) |
|
@wpjunior BTW, I have an another suggestion for you about this pull request. |
|
Hi @u5surf, Creating filters is a powerful tool. However, the current implementation seems to generate Prometheus metrics with two somewhat confusing dimensions: filter and filter_name. Making the status code a first-class attribute would simplify the metrics, making them easier for entry-level users to adopt. Yeah, let's talk on LinkedIn! |
| vtsn->stat_out_bytes); | ||
|
|
||
| if (ctx->measure_status_codes != NULL && vtsn->stat_status_code_counter != NULL) { | ||
| ngx_uint_t *status_code = NULL; |
There was a problem hiding this comment.
Co-authored-by: Y.Horie <[email protected]>
|
@wpjunior In addition some nit picks. At last I would be merge this if you will have finished some fixes. Thanks for a while! @SuperQ Could you review this PR? Because this is a significant change for this module. For we have to make a decision to merge this, I'd like hear more collaboraters agree with the feature or not. |
#154