-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per code distribution by default #154
Comments
Ping @vozlt ? Highly needed feature :( |
@vozl, @freeseacher, @Frodox, @u5surf, @u5surf I am willing to implement this, but I have doubts about how to store the counter for status codes ranging from 100 to 599. Option 1: Store as a sequential array in memory
Option 2: Store in an rbtree (Red-Black Tree)
Option 1.2: Allow users to specify, via a directive, the status codes they want to measure
vhost_traffic_status_measure_status_codes
100 101
200 201 202 204
301 302 303 304 307 308
400 401 403 404 405 406 408 409 410 413 415 429
500 501 502 503 504 505;
|
Thanks some suggestions. In personally I consider that counters are favourous to be more elaborate that you told. On the other hand, user often have handreds or thousands more incredible number of virtual hosts. Their counter nodes and also their upstream counter nodes contain in the rbtree on this module. To be more extend counter accuracy, it has to allocate more memory per a node anyway. In short, we consider that it is necessary to accept their cost, complexity, the trade off their computer resources and provide them We feel like it's more complicated than making just a feature or an enhancement. Ofcource, we are affirmative to your contribution that can be a suitable solution for their background hidden issues. |
@u5surf I designed it to fit many scenarios:
Please review my code. I'm a bit out of practice with C programming. |
Currently there are way to make vts export data by status code and default is to response only with grouped by first digit.
Some error codes for example 499 on load balancer is not behave them self as others in group.
The text was updated successfully, but these errors were encountered: