[CI] Disable spawn when running V1 Test #14345
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that V1 Test is failing on main branch ever since we merged: #14243
The error suggests that the monkeypatch that is used in
test_engine_core_client
does not get picked up when using spawn. It looks like this is a known issue with monkeypatch.If we really need to use spawn for this test, a proper solution would be to re-write the test to not use monkeypatch. However, since this issue is actually failing all PR builds currently I would suggest reverting using spawn when running this test (since they seem to pass).
Have confirmed this reproduces locally and disabling spawn resolves it.
cc @russellb @youkaichao @aarnphm