Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Disable spawn when running V1 Test #14345

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tdoublep
Copy link
Member

@tdoublep tdoublep commented Mar 6, 2025

I noticed that V1 Test is failing on main branch ever since we merged: #14243

The error suggests that the monkeypatch that is used in test_engine_core_client does not get picked up when using spawn. It looks like this is a known issue with monkeypatch.

If we really need to use spawn for this test, a proper solution would be to re-write the test to not use monkeypatch. However, since this issue is actually failing all PR builds currently I would suggest reverting using spawn when running this test (since they seem to pass).

Have confirmed this reproduces locally and disabling spawn resolves it.

cc @russellb @youkaichao @aarnphm

Copy link

github-actions bot commented Mar 6, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant