Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Use spawn multiprocessing mode for V1 test pipeline #14243

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

russellb
Copy link
Member

@russellb russellb commented Mar 4, 2025

I've seen multiple failures related to forking new processes after
cuda has been initialized in this pipeline. Other pipelines use spawn,
so this change applies the same to this one.

Signed-off-by: Russell Bryant [email protected]

I've seen multiple failures related to forking new processes after
cuda has been initialized in this pipeline. Other pipelines use `spawn`,
so this change applies the same to this one.

Signed-off-by: Russell Bryant <[email protected]>
Copy link

github-actions bot commented Mar 4, 2025

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Mar 4, 2025
@simon-mo simon-mo merged commit ffad943 into vllm-project:main Mar 6, 2025
18 checks passed
@youkaichao
Copy link
Member

@russellb can you help investigate which line initializes cuda too early?

@youkaichao
Copy link
Member

you can check https://github.com/vllm-project/vllm/blob/main/tests/standalone_tests/lazy_imports.py to see how to find the first line that does anything (e.g. initialize cuda, imports a module).

johnnynunez pushed a commit to johnnynunez/vllm that referenced this pull request Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants