Also run on pushes to main
#1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Domenic Barbuzzi <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
dsikka
approved these changes
Jan 20, 2025
kylesayrs
approved these changes
Jan 20, 2025
|
For posterity regarding “Changes tested externally.” — when I was initially setting up the changes from #1079, I mirrored the logic/conditionals used in a workflow on a repo of my own so I could test throughout the entire lifecycle of a change. Thus, for this PR, I also developed in that mirror and copied the changes once verified that they would run on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
In #1079, the transformers tests were put behind a 'ready' label on pull requests only. This PR updates that workflow to also run that test job on pushes to
main(e.g. after a PR is merged).TEST PLAN:
Changes tested externally.