Require 'ready' label for transformers tests #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Domenic Barbuzzi <[email protected]>
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to trigger the transformers tests. |
|
Commenting here: At this stage, all workflows/jobs except the |
|
Commenting after adding the 'ready' label: The |
dsikka
previously approved these changes
Jan 17, 2025
Signed-off-by: Domenic Barbuzzi <[email protected]>
dsikka
approved these changes
Jan 17, 2025
dsikka
pushed a commit
that referenced
this pull request
Jan 20, 2025
SUMMARY: In #1079, the transformers tests were put behind a 'ready' label on pull requests only. This PR updates that workflow to also run that test job on pushes to `main` (e.g. after a PR is merged). TEST PLAN: Changes tested externally. Signed-off-by: Domenic Barbuzzi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY:
This PR moves the
transformers-testsjob to its own workflow which only runs on a PR that has the 'ready' label. With this implementation, if the PR already has the 'ready' label when a new commit is pushed, the new commit will re-run the job. I also updated the PR comment workflow to note that the 'ready' label must be added to run this job.There are some visual warts/caveats that come with these triggers because the filtering cannot be done by the triggers, only the jobs:
Whenever a label is added or a commit is pushed, the workflow will still be triggered. However, if the PR does not have the 'ready' label, the
transformers-testsjob will be skipped. While the job being skipped means the runner/resources will not actually be used, it also means that the workflow/job will still show up in various places in the GitHub UI (Actions tab, PR checks). It will show as skipped, but it will still allow the green check mark because that appears as long as there are no failures.Basically, this means that reviews/people able to merge will need to pay closer attention to the jobs run on the PR to make sure that the
transformers-testsjob was run/not skipped.TEST PLAN:
Should affect this PR.