test: fix compatibility with Tarantool master #295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New behavior: SELECT scan queries are only allowed if the SEQSCAN keyword is used correctly[1]. 1. https://www.tarantool.io/en/doc/latest/reference/reference_lua/compat/sql_seq_scan_default/ Related to tarantool/tarantool#8602
oleg-jukovec
force-pushed
the
oleg-jukovec/fix-seq-scan
branch
from
6d7579b to
82a6f1d
Compare
better0fdead
approved these changes
May 24, 2023
| query := "SELECT * FROM seqscan data;" | ||
| if isSeqScanOld, err := test_helpers.IsTarantoolVersionLess(3, 0, 0); err != nil { | ||
| t.Fatal("Could not check the Tarantool version") | ||
| } else if isSeqScanOld { |
There was a problem hiding this comment.
Btw, Seqscan was introduced in 2.11.0-rc1 (but it's not required by default), so you may use this condition too.
There was a problem hiding this comment.
I think it is a good idea to test the default, which is 'old' for 2.11 and 'new` (with seqscan key word) in 3.0 and up.
oleg-jukovec
force-pushed
the
oleg-jukovec/fix-seq-scan
branch
4 times, most recently
from
b950746 to
82a6f1d
Compare
GRISHNOV
approved these changes
May 25, 2023
oleg-jukovec
added a commit
that referenced
this pull request
May 29, 2023
Overview
New features
Connection.CloseGraceful() unlike Connection.Close() waits for all
requests to complete (#257).
ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
for all requests to complete (#257).
ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
from a pool (#290).
Other
Updates crud tests with Tarantool 3.0 (#293).
Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec
added a commit
that referenced
this pull request
May 29, 2023
Overview
The release introduces the ability to gracefully close Connection
and ConnectionPool and also provides methods for adding or removing
an endpoint from a ConnectionPool.
Breaking changes
There are no breaking changes in the release.
New features
Connection.CloseGraceful() unlike Connection.Close() waits for all
requests to complete (#257).
ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
for all requests to complete (#257).
ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
from a pool (#290).
Other
Updates crud tests with Tarantool 3.0 (#293).
Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec
added a commit
that referenced
this pull request
May 29, 2023
Overview
The release introduces the ability to gracefully close Connection
and ConnectionPool and also provides methods for adding or
removing an endpoint from a ConnectionPool.
Breaking changes
There are no breaking changes in the release.
New features
Connection.CloseGraceful() unlike Connection.Close() waits for all
requests to complete (#257).
ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
for all requests to complete (#257).
ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
from a pool (#290).
Other
Updates crud tests with Tarantool 3.0 (#293).
Updates SQL tests with Tarantool 3.0 (#295).
Merged
oleg-jukovec
added a commit
that referenced
this pull request
Jun 6, 2023
Overview
The release introduces the ability to gracefully close Connection
and ConnectionPool and also provides methods for adding or
removing an endpoint from a ConnectionPool.
Breaking changes
There are no breaking changes in the release.
New features
Connection.CloseGraceful() unlike Connection.Close() waits for all
requests to complete (#257).
ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
for all requests to complete (#257).
ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
from a pool (#290).
Other
Updates crud tests with Tarantool 3.0 (#293).
Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec
added a commit
that referenced
this pull request
Jun 7, 2023
Overview
The release introduces the ability to gracefully close Connection
and ConnectionPool and also provides methods for adding or
removing an endpoint from a ConnectionPool.
Breaking changes
There are no breaking changes in the release.
New features
Connection.CloseGraceful() unlike Connection.Close() waits for all
requests to complete (#257).
ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
for all requests to complete (#257).
ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
from a pool (#290).
Other
Updates crud tests with Tarantool 3.0 (#293).
Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec
added a commit
that referenced
this pull request
Jun 7, 2023
Overview
The release introduces the ability to gracefully close Connection
and ConnectionPool and also provides methods for adding or
removing an endpoint from a ConnectionPool.
Breaking changes
There are no breaking changes in the release.
New features
Connection.CloseGraceful() unlike Connection.Close() waits for all
requests to complete (#257).
ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
for all requests to complete (#257).
ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
from a pool (#290).
Other
Updates crud tests with Tarantool 3.0 (#293).
Updates SQL tests with Tarantool 3.0 (#295).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New behavior: SELECT scan queries are only allowed if the SEQSCAN keyword is used correctly[1].
I didn't forget about (remove if it is not applicable):
Related issues:
tarantool/tarantool#8602