Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graceful shutdown from a client side #257

Closed
oleg-jukovec opened this issue Dec 28, 2022 · 0 comments · Fixed by #296
Closed

Graceful shutdown from a client side #257

oleg-jukovec opened this issue Dec 28, 2022 · 0 comments · Fixed by #296
Assignees
@oleg-jukovec
Labels
feature A new functionality good first issue Good for newcomers teamE

Comments

@oleg-jukovec
Copy link
Collaborator

oleg-jukovec commented Dec 28, 2022 •
edited
Loading

It would be nice to wait for all requests to be completed and don't send a new one (should be already implemented) if a user call Connection.Close() or ConnectionPool.Close(). See the feature request:

#214 (comment)
@oleg-jukovec oleg-jukovec added feature A new functionality 3sp labels Dec 28, 2022
@oleg-jukovec oleg-jukovec mentioned this issue Dec 28, 2022
Closed
@oleg-jukovec oleg-jukovec changed the title graceful shutdown from a client side Graceful shutdown from a client side Dec 28, 2022
@oleg-jukovec oleg-jukovec added the good first issue Good for newcomers label Dec 28, 2022
@oleg-jukovec oleg-jukovec mentioned this issue May 11, 2023
Closed
@oleg-jukovec oleg-jukovec self-assigned this May 24, 2023
oleg-jukovec added a commit that referenced this issue May 24, 2023
@oleg-jukovec
godoc: add a note abount Shutdown state
3877378 
We forgot to update a comment about the state.

Part of #257
oleg-jukovec added a commit that referenced this issue May 24, 2023
@oleg-jukovec
api: graceful Connection.Close()
aa29a82 
Connection.Close() waits for all active requests to complete.

Part of #257
oleg-jukovec added a commit that referenced this issue May 25, 2023
@oleg-jukovec
godoc: add a note abount Shutdown state
ea4783f 
We forgot to update a comment about the state.

Part of #257
oleg-jukovec added a commit that referenced this issue May 25, 2023
@oleg-jukovec
api: add Connection.CloseGraceful()
53d9c2b 
CloseGraceful closes Connection gracefully. Unlike Connection.Close()
it waits for all requests to complete.

Part of #257
oleg-jukovec added a commit that referenced this issue May 25, 2023
@oleg-jukovec
api: add Connection.CloseGraceful()
78657eb 
CloseGraceful closes Connection gracefully. Unlike Connection.Close()
it waits for all requests to complete.

Part of #257
oleg-jukovec added a commit that referenced this issue May 25, 2023
@oleg-jukovec
api: add Connection.CloseGraceful()
b3f9dd6 
CloseGraceful closes Connection gracefully. Unlike Connection.Close()
it waits for all requests to complete.

Part of #257
oleg-jukovec added a commit that referenced this issue May 25, 2023
@oleg-jukovec
api: add Connection.CloseGraceful()
352a5c4 
CloseGraceful closes Connection gracefully. Unlike Connection.Close()
it waits for all requests to complete.

Part of #257
oleg-jukovec added a commit that referenced this issue May 26, 2023
@oleg-jukovec
godoc: add a note abount Shutdown state
c86dafd 
We forgot to update a comment about the state.

Part of #257
oleg-jukovec added a commit that referenced this issue May 26, 2023
@oleg-jukovec
api: add Connection.CloseGraceful()
9dbb025 
CloseGraceful closes Connection gracefully. Unlike Connection.Close()
it waits for all requests to complete.

Part of #257
oleg-jukovec added a commit that referenced this issue May 26, 2023
@oleg-jukovec
api: add ConnectionPool.CloseGraceful()
d4b7b25 
CloseGraceful closes ConnectionPool gracefully. Unlike
ConnectionPool.Close() it waits for all requests to complete.

Closes #257
@oleg-jukovec oleg-jukovec mentioned this issue May 26, 2023
Merged
3 tasks
oleg-jukovec added a commit that referenced this issue May 26, 2023
@oleg-jukovec
godoc: add a note about Shutdown state
642dfb3 
We forgot to update a comment about the state.

Part of #257
oleg-jukovec added a commit that referenced this issue May 26, 2023
@oleg-jukovec
api: add Connection.CloseGraceful()
a3f62d6 
CloseGraceful closes Connection gracefully. Unlike Connection.Close()
it waits for all requests to complete.

Part of #257
oleg-jukovec added a commit that referenced this issue May 26, 2023
@oleg-jukovec
api: add ConnectionPool.CloseGraceful()
2be2bdb 
CloseGraceful closes ConnectionPool gracefully. Unlike
ConnectionPool.Close() it waits for all requests to complete.

Closes #257
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
Release 1.12.0
59a709b 
Overview

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
Release 1.12.0
9fb0943 
Overview

The release introduces the ability to gracefully close Connection
and ConnectionPool and also provides methods for adding or removing
an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
Release 1.12.0
238562f 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
@oleg-jukovec oleg-jukovec mentioned this issue May 29, 2023
Merged
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
godoc: add a note about Shutdown state
c7c577e 
We forgot to update a comment about the state.

Part of #257
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
api: add Connection.CloseGraceful()
dccf688 
CloseGraceful closes Connection gracefully. Unlike Connection.Close()
it waits for all requests to complete.

Part of #257
oleg-jukovec added a commit that referenced this issue May 29, 2023
@oleg-jukovec
api: add ConnectionPool.CloseGraceful()
897ba41 
CloseGraceful closes ConnectionPool gracefully. Unlike
ConnectionPool.Close() it waits for all requests to complete.

Closes #257
oleg-jukovec added a commit that referenced this issue Jun 6, 2023
@oleg-jukovec
Release 1.12.0
5fff2f0 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue Jun 7, 2023
@oleg-jukovec
Release 1.12.0
1d2d5cd 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
oleg-jukovec added a commit that referenced this issue Jun 7, 2023
@oleg-jukovec
Release 1.12.0
403f2c3 
Overview

    The release introduces the ability to gracefully close Connection
    and ConnectionPool and also provides methods for adding or
    removing an endpoint from a ConnectionPool.

Breaking changes

    There are no breaking changes in the release.

New features

    Connection.CloseGraceful() unlike Connection.Close() waits for all
    requests to complete (#257).

    ConnectionPool.CloseGraceful() unlike ConnectionPool.Close() waits
    for all requests to complete (#257).

    ConnectionPool.Add()/ConnectionPool.Remove() to add/remove endpoints
    from a pool (#290).

Other

    Updates crud tests with Tarantool 3.0 (#293).

    Updates SQL tests with Tarantool 3.0 (#295).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oleg-jukovec oleg-jukovec

Labels
feature A new functionality good first issue Good for newcomers teamE
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

api: add Connection.CloseGraceful() and ConnectionPool.CloseGraceful() tarantool/go-tarantool
2 participants
@oleg-jukovec @LeonidVas