Support Browserify and related refactoring #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, supporting Browserify required a lot of refactoring. Below is a list of the changes required to support Browserify: * Source restructuring so that sources now are Node.js modules and Browserify use used to build the browser binaries * NPM was cleaned up so that only the required files are packaged for NPM * Gulp file was restructured to build with Browserify * Removed all globals and unnecessary objects/functions from the exports * Removed shred and replaced with Superagent Fixes #187 Fixes #208 Fixes #267 Others are possibly fixed but I'd rather add tests to ensure they are.
This was referenced Mar 7, 2015
Closed
whitlockjc
added a commit
that referenced
this pull request
Mar 9, 2015
Support Browserify and related refactoring
|
@fehguy gave me the +1 to merge since all tests pass and preliminary testing with swagger-ui was fine. Since we did remove Shred and switched to Superagent I am aware that some things could have changed that will require some follow-up work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, supporting Browserify required a lot of refactoring.
Below is a list of the changes required to support Browserify:
Browserify use used to build the browser binaries
NPM
Fixes #178
Fixes #208
Fixes #267
Others are possibly fixed but I'd rather add tests to ensure they are.