-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch from shred to super agent? #267
Comments
This bug(swagger-api/swagger-ui#956) is a result of bugs in shred library. the |
👍 also jquery http-client (even dependency) can be ditched in the process. |
There was also this use case with file uploads not exactly working with shred explained more recently in #231 |
I'm going to do this after I get the current browserify/cleanup done, which should be today. |
@aurelian does super agent encode support uploading files via FormData? |
This should be done as of #279. It's not fully tested but swagger-js and swagger-ui tests pass with this implementation. I am sure swagger-ui will help us find anomalies as will our adding of new tests. |
#279 has been merged so superagent is now being used instead of shred. |
Seems like the shred version we're on is broken for some important use cases, and their API has changed considerably. Can we move to super agent instead? @whitlockjc might be able to assess.
I would simply add it to the
swaggerHttp.js
class and should be 100% transparentThe text was updated successfully, but these errors were encountered: