Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch from shred to super agent? #267

Closed
fehguy opened this issue Mar 3, 2015 · 8 comments
Closed

switch from shred to super agent? #267

fehguy opened this issue Mar 3, 2015 · 8 comments
Assignees
Labels
Milestone

Comments

@fehguy
Copy link
Contributor

fehguy commented Mar 3, 2015

Seems like the shred version we're on is broken for some important use cases, and their API has changed considerably. Can we move to super agent instead? @whitlockjc might be able to assess.

I would simply add it to the swaggerHttp.js class and should be 100% transparent

@mohsen1
Copy link
Contributor

mohsen1 commented Mar 3, 2015

This bug(swagger-api/swagger-ui#956) is a result of bugs in shred library.

the parseUri function has a bug that can't parse a URI with @ in it.

@aurelian
Copy link
Contributor

aurelian commented Mar 5, 2015

👍 also jquery http-client (even dependency) can be ditched in the process.

@aurelian
Copy link
Contributor

aurelian commented Mar 5, 2015

There was also this use case with file uploads not exactly working with shred explained more recently in #231

@whitlockjc
Copy link
Contributor

I'm going to do this after I get the current browserify/cleanup done, which should be today.

@fehguy
Copy link
Contributor Author

fehguy commented Mar 5, 2015

@aurelian does super agent encode support uploading files via FormData?

@aurelian
Copy link
Contributor

aurelian commented Mar 5, 2015

@fehguy -- it should, but haven't used it myself.

@whitlockjc
Copy link
Contributor

This should be done as of #279. It's not fully tested but swagger-js and swagger-ui tests pass with this implementation. I am sure swagger-ui will help us find anomalies as will our adding of new tests.

@whitlockjc
Copy link
Contributor

#279 has been merged so superagent is now being used instead of shred.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants