-
-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose new base class method 'unconstrain_array' #3179
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveBronder
approved these changes
May 4, 2023
rok-cesnovar
approved these changes
May 4, 2023
This was referenced May 4, 2023
This was referenced Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submission Checklist
./runTests.py src/test/unit
make cpplint
Summary
This exposes the method added in stan-dev/stanc3#1305 as a direct inverse function for
write_array
.unconstrain_array
takes in a vector of parameters on the constrained scale in the same order thatwrite_array
produced them and produces a vector of parameters on the unconstrained scale in the same order thatwrite_array
andlog_prob
expect.This allows us to write what we want to write in almost all cases where we are using
array_var_context
followed bytransform_inits
at the moment (standalone generated quantities, thelog_prob
service function, etc). This is very useful for new features like tuples, ragged arrays, etc, since it weakens the reliance on themodel.get_dims()
function which fundamentally assumes that parameters are rectangular.Intended Effect
Exposes
unconstrain_array
to the model base class. This function is already generated by the compiler.How to Verify
Tests are added for the function directly and the standalone generated quantities service has been updated to use this new code.
Side Effects
None
Documentation
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: