Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use unconstrain_array in CmdStan #1163

Merged
merged 4 commits into from
May 5, 2023
Merged

Use unconstrain_array in CmdStan #1163

merged 4 commits into from
May 5, 2023

Conversation

WardBrian
Copy link
Member

@WardBrian WardBrian commented May 4, 2023

Submisison Checklist

  • Run tests: ./runCmdStanTests.py src/test
  • Declare copyright holder and open-source license: see below

Summary:

Follow on to stan-dev/stan#3179. This replaces the array_var_context/transform_inits combo with a call to unconstrain_array.

It also makes some related cleanups to existing calls of transform_inits, since now (as of stan-dev/stanc3#1316), transform_inits now does validation on the var context it receives.

I also fixed up a couple small typos and some other minor things in docstrings.

Intended Effect:

Clean up various ways of unconstraining parameters, with the express goal being to make tuples easier to handle by delegating more to the compiler.

How to Verify:

Side Effects:

None

Documentation:

Existing docstrings updated as apropriate

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Simons Foundation

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

Copy link
Member

@mitzimorris mitzimorris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@WardBrian WardBrian merged commit 46e26cb into develop May 5, 2023
@WardBrian WardBrian deleted the use-unconstrain-array branch May 5, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants