Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submisison Checklist
./runCmdStanTests.py src/test
Summary:
Follow on to stan-dev/stan#3179. This replaces the
array_var_context
/transform_inits
combo with a call tounconstrain_array
.It also makes some related cleanups to existing calls of
transform_inits
, since now (as of stan-dev/stanc3#1316),transform_inits
now does validation on the var context it receives.I also fixed up a couple small typos and some other minor things in docstrings.
Intended Effect:
Clean up various ways of unconstraining parameters, with the express goal being to make tuples easier to handle by delegating more to the compiler.
How to Verify:
Side Effects:
None
Documentation:
Existing docstrings updated as apropriate
Copyright and Licensing
Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):
Simons Foundation
By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses: