Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing dependency on Starlette #149

Closed
synapticarbors opened this issue Oct 4, 2022 · 1 comment
Closed

Missing dependency on Starlette #149

synapticarbors opened this issue Oct 4, 2022 · 1 comment

Comments

@synapticarbors
Copy link

fastapi-mail has an explicit dependency on starlette that is missing in the pyproject.toml. It probably doesn't show up often because people are usually installing this package alongside fastapi, which pulls it in, but I noticed when I was packaging this package for conda-forge and building the package in isolation.

@sabuhish
Copy link
Owner

sabuhish commented Oct 6, 2022

You are totally right, I have missed this. I was also using it without fastapi, I will take care of it today, thanks for pointing on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants