Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency hiccups? #147

Closed
tammoippen opened this issue Oct 2, 2022 · 1 comment
Closed

Dependency hiccups? #147

tammoippen opened this issue Oct 2, 2022 · 1 comment

Comments

@tammoippen
Copy link

Hi there, agian :D

I think there might be some dependency hiccups:

  • in [tool.poetry.dependencies] you have fakeredis (also as a optional dep), but in the library code you do not use it. Also, fakeredis is already part of the [tool.poetry.dev-dependencies] (where it belongs). here
  • aioredis is only part of [tool.poetry.dev-dependencies], even though it is used in email_check - making that part of the code unusable for external projects (except they install aioredis themself as a peer dependency)

Thanks again for the library!

@sabuhish
Copy link
Owner

sabuhish commented Oct 6, 2022

Hi @tammoippen

Ups, that that fakeredis was not suppose to be optional, I misconfigured it. aioredis must be the optional to be installed.
Meaning both httpx and aioredis can be installed as an extra dependency. When installing fastapi-mail it wont be installed. Those should be installed with the following commands:

pip install fastapi-mail[aioredis]
pip install fastapi-mail[httpx]

I have opened branch currently working on it, will submit PR and merge it to the master soon. Thanks!

sabuhish added a commit that referenced this issue Oct 6, 2022
sabuhish added a commit that referenced this issue Oct 11, 2022
* v1.1.6 closes #149 #147 #146

* v1.1.6 fix group dependecies

* Fully updated repo

* fix linter issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants