Fix tabColor arg crash in CommandPalette #10096
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-CmdPal
DHowett
approved these changes
May 17, 2021
|
Thanks and welcome back @leonMSFT! |
DHowett
pushed a commit
that referenced
this pull request
May 24, 2021
While a user is formulating their hex string for a `tabColor` arg in the CommandPalette, we try to parse the string one char at a time as it comes in. `ColorFromHexString` doesn't like anything except a well formed hex string so it'll throw. We can probably eat any error that comes out of this because we should only care to set the TabColor once the string provided is a valid hex str. Closes #10053 (cherry picked from commit f7458a3)
|
🎉 Handy links: |
ghost
mentioned this pull request
|
🎉 Handy links: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While a user is formulating their hex string for a
tabColorargin the CommandPalette, we try to parse the string one char at
a time as it comes in.
ColorFromHexStringdoesn't like anythingexcept a well formed hex string so it'll throw. We can probably eat
any error that comes out of this because we should only care to set
the TabColor once the string provided is a valid hex str.
Closes #10053