Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal crashes when setting --tabColor in command line arguments #10053

Closed
MSEvanhi opened this issue May 7, 2021 · 5 comments · Fixed by #10096
Closed

Terminal crashes when setting --tabColor in command line arguments #10053

MSEvanhi opened this issue May 7, 2021 · 5 comments · Fixed by #10096
Assignees
@leonMSFT
Labels
Area-CmdPal Command Palette issues and features Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Milestone
Terminal v2.0

Comments

@MSEvanhi
Copy link
Member

MSEvanhi commented May 7, 2021

Windows Terminal version (or Windows build number)

10.0.19042.0, 1.7.1033.0

Other Software

Not other software, but I notice your default Windows Terminal version listed above is higher than my terminal version. I obtained mine from the Windows Store yesterday, so maybe this is fixed in a later version and you have yet to release that to the store?

Steps to reproduce

  1. Open Windows Terminal command line.
  2. Attempt to create a new split window (vertical or horizontal) and set --tabColor
  3. When typing past 1 character of tabColor, the terminal window will crash.

Expected Behavior

For me to be able to type out my color value and not crash.

Actual Behavior

Window crashes.
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 7, 2021
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Severity-Crash Crashes are real bad news. labels May 10, 2021
@zadjii-msft
Copy link
Member

Wait, does the terminal that you're typing in crash, or does the terminal that launches crash?

What shell are you using?

@zadjii-msft zadjii-msft added the Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something label May 11, 2021
@MSEvanhi
Copy link
Member Author

MSEvanhi commented May 12, 2021 •
edited
Loading

does the terminal that you're typing in crash, or does the terminal that launches crash?

  • I am using a single Windows Terminal window. I default to my PowerShell profile. I get the issue when attempting to use: sp -H -p PowerShell --tabColor #FFFFFF in the 'command pallet'. The Windows Terminal itself crashes, taking all tabs I have with it.

What shell are you using?

  • I default to PowerShell, but I know this crashes my Windows Terminal window no matter which profile/shell I'm using.

@ghost ghost added Needs-Attention The core contributors need to come back around and look at this ASAP. and removed Needs-Author-Feedback The original author of the issue/PR needs to come back and respond to something labels May 12, 2021
@zadjii-msft
Copy link
Member

Oh wow okay yep, that clears it up. Didn't realize it was the command palette! That crashes instantaneously. That we can work with, thanks!

@zadjii-msft zadjii-msft added Area-CmdPal Command Palette issues and features Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) and removed Needs-Attention The core contributors need to come back around and look at this ASAP. labels May 12, 2021
@zadjii-msft zadjii-msft added this to the Terminal v2.0 milestone May 12, 2021
@DHowett DHowett removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 13, 2021
@ghost ghost added the Needs-Tag-Fix Doesn't match tag requirements label May 13, 2021
@leonMSFT leonMSFT self-assigned this May 13, 2021
@leonMSFT leonMSFT mentioned this issue May 14, 2021
Merged
@ghost ghost added the In-PR This issue has a related PR label May 14, 2021
@ghost ghost added Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed In-PR This issue has a related PR labels May 17, 2021
DHowett pushed a commit that referenced this issue May 17, 2021
@leonMSFT
Fix tabColor arg crash in CommandPalette (#10096)
f7458a3 
While a user is formulating their hex string for a `tabColor` arg
in the CommandPalette, we try to parse the string one char at
a time as it comes in. `ColorFromHexString` doesn't like anything
except a well formed hex string so it'll throw. We can probably eat
any error that comes out of this because we should only care to set 
the TabColor once the string provided is a valid hex str.

Closes #10053
DHowett pushed a commit that referenced this issue May 24, 2021
@leonMSFT @DHowett
Fix tabColor arg crash in CommandPalette (#10096)
7264d5c 
While a user is formulating their hex string for a `tabColor` arg
in the CommandPalette, we try to parse the string one char at
a time as it comes in. `ColorFromHexString` doesn't like anything
except a well formed hex string so it'll throw. We can probably eat
any error that comes out of this because we should only care to set
the TabColor once the string provided is a valid hex str.

Closes #10053

(cherry picked from commit f7458a3)
@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #10096, which has now been successfully released as Windows Terminal v1.8.1444.0.:tada:

Handy links:

@ghost
Copy link

ghost commented May 25, 2021

🎉This issue was addressed in #10096, which has now been successfully released as Windows Terminal Preview v1.9.1445.0.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leonMSFT leonMSFT

Labels
Area-CmdPal Command Palette issues and features Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Resolution-Fix-Committed Fix is checked in, but it might be 3-4 weeks until a release. Severity-Crash Crashes are real bad news.
Projects
None yet
Milestone
Terminal v2.0
Development

Successfully merging a pull request may close this issue.

Fix tabColor arg crash in CommandPalette microsoft/terminal
4 participants
@DHowett @MSEvanhi @zadjii-msft @leonMSFT