Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse "PreCD" stage #266

Merged
merged 2 commits into from
Mar 29, 2024
Merged

Parse "PreCD" stage #266

merged 2 commits into from
Mar 29, 2024

Conversation

mico
Copy link
Contributor

@mico mico commented Mar 13, 2024

closes #76

@mico mico requested review from ronaldtse and opoudjis March 13, 2024 02:37
ronaldtse
ronaldtse requested changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@ronaldtse ronaldtse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add to documentation that we’re using a special stage called “29” that is not in the International Harmonized Codes to represent the “PreCD” stage.

@mico mico requested a review from ronaldtse March 21, 2024 13:34
@mico mico merged commit df64d77 into main Mar 29, 2024
28 of 29 checks passed
@mico mico deleted the parse-precd branch March 29, 2024 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@opoudjis opoudjis opoudjis approved these changes

@ronaldtse ronaldtse Awaiting requested review from ronaldtse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handling non-standard "pre{STAGE}" identifiers
3 participants
@mico @ronaldtse @opoudjis