enable livereload on directories, not strictly files ending with .html (fixes #72)

[cvan]

No description provided.

[cvan]

here's a prior patch, but I like this better

[mattdesl]

I added example/demo/index.html and tried testing like so:

./bin/cmd.js test/fixtures/app:bundle.js --dir example/ --live | garnish

But the index.html request never finishes. This is something to do with inject-lr-script.

Could also explore inject-lr-script-stream and avoid the mime-type check, but might involve changing ecstatic to something simpler like filed.

[cvan]

But the index.html request never finishes. This is something to do with inject-lr-script.

Yep, I noticed that on budo master too. I was going to troubleshoot that but forgot. Separate issue?

[mattdesl]

Ah must be a separate issue then 😄

[cvan]

Yep, I noticed that on budo master too. I was going to troubleshoot that but forgot. Separate issue?

Actually, looks like I regressed it here heh. Investigating…

[cvan]

But a similar issue exists on master:

http://localhost:9966/404.html response will never finish.

---

Filed mattdesl/inject-lr-script#3.

[cvan]

would you be willing to merge this? I still am encountering #79 but it looks to be a separate issue. and I spent some time trying to tackle #80, but it took quite some time - would like to revisit it sometime though.

[mattdesl]

I just tested again and it doesn't seem to hang. Merged! Thanks

[mattdesl]

I'm doing more tests locally and this seems to break some functionality. It looks like images and other files are getting picked up by the regex. I will keep investigating.

[mattdesl]

I added a new regex when not in --pushstate mode, let me know if it's working in v7.