Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LiveReload injected script often hangs the page on load #79

Closed
cvan opened this issue Sep 29, 2015 · 5 comments
Closed

LiveReload injected script often hangs the page on load #79

cvan opened this issue Sep 29, 2015 · 5 comments

Comments

@cvan
Copy link
Contributor

cvan commented Sep 29, 2015

Seems to happen in both Chrome and Firefox. Not sure if it's a regression or if it's a problem with inject-lr-script.

@cvan cvan changed the title LiveReload injecte script hangs the page in Firefox LiveReload injected script hangs the page in Firefox Sep 29, 2015
@cvan cvan changed the title LiveReload injected script hangs the page in Firefox LiveReload injected script often hangs the page on load Sep 29, 2015
@cvan
Copy link
Contributor Author

cvan commented Dec 1, 2015

I see this when opening multiple tabs of pages that are served via budo w/ LiveReload:

screenshot 2015-11-14 17 34 34

screenshot 2015-11-14 17 34 22

@yoshuawuyts
Copy link
Collaborator

Hmh, it might be since it's setting attaching a bunch of event listeners internally. I wrote inject-lr-script-stream which might be a way to resolve this, though it may not fit in with the current budo architecture.

@cvan
Copy link
Contributor Author

cvan commented Dec 3, 2015

This prevents me from using LiveReload with more than one tab unfortunately. Just curious if anyone has been able to reproduce this, or if it's just me.

@mattdesl
Copy link
Owner

mattdesl commented Dec 3, 2015

Hmm never seen this and I've done a bunch of dev with multiple tabs, browsers, and devices open. What version of node are you using? Have you tried removing node_modules and reinstalling?

And yeah, hopefully next week I will have a bit of time to revisit using filed instead of ecstatic, but it may involve a few other hurdles like directory listings and such.

@mattdesl
Copy link
Owner

This should be fixed in 8.0.0. Please test and let me know if you see it again. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants