Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sumcheck protocol #973

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
+653 −90
Open

Add sumcheck protocol #973

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
ad8be02
first sumcheck protocol iteration
jotabulacios Feb 25, 2025
6790426
save work
jotabulacios Feb 25, 2025
a311b30
save work.Protocol is almost ready
jotabulacios Feb 26, 2025
c29a94d
refactor code
jotabulacios Feb 26, 2025
b78c3b6
improve code
jotabulacios Feb 27, 2025
70e8240
Refactor: move sumcheck protocol into provers
jotabulacios Feb 27, 2025
17b94d8
fix clippy
jotabulacios Feb 27, 2025
0bb40c0
fix wasm32 error
jotabulacios Feb 27, 2025
0c23101
fix comments
jotabulacios Mar 7, 2025
a2418f8
Merge branch 'main' into add_sumcheck
jotabulacios Mar 7, 2025
c8f3822
fix comments
jotabulacios Mar 10, 2025
1f40f8b
add doc explaining fix_last_variable function
jotabulacios Mar 10, 2025
98320e4
implement From trait for DenseMultilinearPolynomial
jotabulacios Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 26 additions & 7 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,24 @@
[workspace]

members = ["math", "crypto", "gpu", "benches", "provers/plonk", "provers/stark", "provers/groth16", "provers/groth16/arkworks-adapter", "provers/groth16/circom-adapter", "examples/merkle-tree-cli", "examples/prove-miden", "provers/winterfell_adapter", "examples/shamir_secret_sharing","examples/pinocchio", "examples/prove-verify-circom", "examples/baby-snark"]
members = [
"math",
"crypto",
"gpu",
"benches",
"provers/plonk",
"provers/sumcheck",
"provers/stark",
"provers/groth16",
"provers/groth16/arkworks-adapter",
"provers/groth16/circom-adapter",
"examples/merkle-tree-cli",
"examples/prove-miden",
"provers/winterfell_adapter",
"examples/shamir_secret_sharing",
"examples/pinocchio",
"examples/prove-verify-circom",
"examples/baby-snark",
]
exclude = ["ensure-no_std"]
resolver = "2"

Expand All @@ -16,16 +34,17 @@ lambdaworks-crypto = { path = "./crypto", version = "0.11.0", default-features =
lambdaworks-gpu = { path = "./gpu", version = "0.11.0" }
lambdaworks-math = { path = "./math", version = "0.11.0", default-features = false }
stark-platinum-prover = { path = "./provers/stark" }
lambdaworks-winterfell-adapter = { path = "./provers/winterfell_adapter"}
lambdaworks-winterfell-adapter = { path = "./provers/winterfell_adapter" }
lambdaworks-groth16 = { path = "./provers/groth16" }
lambdaworks-circom-adapter = { path = "./provers/groth16/circom-adapter" }
lambdaworks-sumcheck = { path = "./provers/sumcheck" }

[patch.crates-io]
winter-air = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4"}
winter-prover = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4"}
winter-math = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4"}
winter-utils = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4"}
winter-crypto = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4"}
winter-air = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4" }
winter-prover = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4" }
winter-math = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4" }
winter-utils = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4" }
winter-crypto = { git = "https://github.com/lambdaclass/winterfell-for-lambdaworks.git", branch = "derive-clone-v6.4" }
miden-air = { git = "https://github.com/lambdaclass/miden-vm" }
miden-core = { git = "https://github.com/lambdaclass/miden-vm" }
miden-assembly = { git = "https://github.com/lambdaclass/miden-vm" }
Expand Down
1 change: 0 additions & 1 deletion crypto/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ serde = { version = "1.0", default-features = false, features = [
"alloc",
], optional = true }
rayon = { version = "1.8.0", optional = true }

[dev-dependencies]
criterion = "0.4"
iai-callgrind.workspace = true
Expand Down
1 change: 1 addition & 0 deletions crypto/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,4 @@ pub mod errors;
pub mod fiat_shamir;
pub mod hash;
pub mod merkle_tree;
//pub mod sumcheck;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you comment this line? it's better to remove it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to delete it. Fixed in c8f3822

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this commented?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to delete it. Fixed in c8f3822

Loading
Loading