Add sumcheck protocol #973
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #973 +/- ##
==========================================
+ Coverage 71.66% 71.90% +0.24%
==========================================
Files 156 159 +3
Lines 34316 34659 +343
==========================================
+ Hits 24593 24923 +330
- Misses 9723 9736 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| poly_evals.push(FieldElement::zero()); | ||
| } | ||
|
|
||
| DenseMultilinearPolynomial { | ||
| evals: poly_evals.clone(), |
There was a problem hiding this comment.
It would be better if we can avoid this clone
| let half = 1 << (n - 1); | ||
| let new_evals: Vec<FieldElement<F>> = (0..half) | ||
| .map(|j| { | ||
| let a = self.evals[j].clone(); |
There was a problem hiding this comment.
same, would be better to work with references
| } | ||
| evaluations.push(self.evaluate(point).unwrap()); | ||
| } | ||
| evaluations |
There was a problem hiding this comment.
Given that we are in Lagrange basis, this is just returning the elements contained in the vector defining the polynomial
|
|
||
| pub trait Channel<F: IsField> { | ||
| fn append_field_element(&mut self, element: &FieldElement<F>); | ||
| fn draw_felt(&mut self) -> FieldElement<F>; |
There was a problem hiding this comment.
i would use consistent naming
provers/sumcheck/src/verifier.rs
Outdated
| let eval_1 = univar.evaluate(&FieldElement::<F>::one()); | ||
|
|
||
| if self.round == 0 { | ||
| println!( |
There was a problem hiding this comment.
why are we keeping the println? The way I see this, the protocol works so long as the polynomial is multilinear
crypto/src/lib.rs
Outdated
| @@ -9,3 +9,4 @@ pub mod errors; | |||
| pub mod fiat_shamir; | |||
| pub mod hash; | |||
| pub mod merkle_tree; | |||
| //pub mod sumcheck; | |||
There was a problem hiding this comment.
why do you comment this line? it's better to remove it
crypto/src/lib.rs
Outdated
| @@ -9,3 +9,4 @@ pub mod errors; | |||
| pub mod fiat_shamir; | |||
| pub mod hash; | |||
| pub mod merkle_tree; | |||
| //pub mod sumcheck; | |||
| } | ||
|
|
||
| /// Constructs a DenseMultilinearPolynomial from a vector of evaluations and the number of variables. | ||
| pub fn from_evaluations_vec(num_vars: usize, evaluations: Vec<FieldElement<F>>) -> Self { |
There was a problem hiding this comment.
this function could be implemented using the From trait
provers/sumcheck/src/verifier.rs
Outdated
| }); | ||
| } | ||
| } else { | ||
| let sum = eval_0.clone() + eval_1.clone(); |
There was a problem hiding this comment.
is it possible to sum without clonning the elements?
Add sumcheck protocol
Description
This PR introduces a basic naive implementation of the Sumcheck Protocol using Multilinear Polynomials.
Type of change