-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/Replication Manager v3 #32
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test only contained unit-tests for the multiplexer with no references or tests related to multifeed.
Closed
Resolved conflict caused by 91e05dc. manually included the same change all tests pass again.
This was referenced Sep 21, 2019
4 tasks
Is this obsolete now that |
Hmm. no it's still the same |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've rewritten the replication management that was previously located in
mux.js
and moved it out into a separate module.
The motivation behind the code separation was driven by the need to use a single
peer connection to replicate multiple 'multifeeds'.
Which in turn led me to the idea that replication and storage management dosen't necessarily
have to be done by the same module.
This enables multifeed to share a replication manager with other core stores or lazily
initialize it's own replication manager when
replicate()
or the newuse()
method is invoked.Multifeed's tests were not modified and were used as proof of fittness for the new replication manager.
Due to the rewrite of error handling we're seeing new warnings during the test-suite run.
Which I believe is positive since we had no feedback nor handling during those states before.
I hope that I have improved the stability as a whole.
The new middleware API allows multifeed dependents to control replication on application level.
I wonder if it could be used to implement a cabal-core#55 exile-filter...
Todo
Tasks left before merge:
use()
methodopts.headerOrigin