Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle hypercore replication timeouts #58

Closed
cblgh opened this issue Sep 21, 2019 · 5 comments
Closed

handle hypercore replication timeouts #58

cblgh opened this issue Sep 21, 2019 · 5 comments
Labels
help wanted Extra attention is needed

Comments

@cblgh
Copy link
Member

cblgh commented Sep 21, 2019

originally suggested by @substack, it seems we have a few connectivity issues for sessions that are open for a long amount of time.

by adding a timeout to the replication stream, we can likely solve the problems we've been seeing

implementation

@cblgh cblgh added the help wanted Extra attention is needed label Sep 21, 2019
@telamon
Copy link
Contributor

telamon commented Sep 21, 2019

Um. i've been working on upgrading the replication to proto7 since last week, you should be able to simply upgrade hypercore dependency to v8 once multifeed pr#32 is merged and my working branch replication#proto7 is merged.

edit: core replication tests passed yesterday (yay!)

@cblgh
Copy link
Member Author

cblgh commented Sep 21, 2019

ohhh that's great news, yr wonderful @telamon ^_^

@hackergrrl
Copy link
Member

[email protected] implements a ping & timeout feature already:

https://github.com/mafintosh/hypercore-protocol/blob/v6.12.0/index.js#L61

Does this not currently work?

@cblgh
Copy link
Member Author

cblgh commented Sep 22, 2019 via email

@hackergrrl
Copy link
Member

I think this ok now that we're on hypercore 8? It sends keep-alive messages every 10s by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants