-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle hypercore replication timeouts #58
Comments
Um. i've been working on upgrading the replication to proto7 since last week, you should be able to simply upgrade hypercore dependency to v8 once multifeed pr#32 is merged and my working branch replication#proto7 is merged. edit: core replication tests passed yesterday (yay!) |
ohhh that's great news, yr wonderful @telamon ^_^ |
https://github.com/mafintosh/hypercore-protocol/blob/v6.12.0/index.js#L61 Does this not currently work? |
Ah, I missed that.
…On Sun, 22 Sep 2019 at 05:55, noffle ***@***.***> wrote:
***@***.*** implements a ping & timeout feature already:
https://github.com/mafintosh/hypercore-protocol/blob/v6.12.0/index.js#L61
Does this not currently work?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#58?email_source=notifications&email_token=AA5O6WW5SJTHRRIU4AIHW5LQK3UEDA5CNFSM4IY5IYRKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD7I552Q#issuecomment-533847786>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA5O6WSJ46LEBDCOWL2A643QK3UEDANCNFSM4IY5IYRA>
.
|
I think this ok now that we're on hypercore 8? It sends keep-alive messages every 10s by default. |
originally suggested by @substack, it seems we have a few connectivity issues for sessions that are open for a long amount of time.
by adding a timeout to the replication stream, we can likely solve the problems we've been seeing
implementation
hypercore@8
hypercore-protocol
methodsstream.setTimeout(ms, ontimeout)
stream.on('timeout', cb)
The text was updated successfully, but these errors were encountered: