-
-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a standalone Modal layout #7083
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7083 +/- ##
========================================
Coverage 86.72% 86.72%
========================================
Files 342 345 +3
Lines 51831 51984 +153
========================================
+ Hits 44952 45085 +133
- Misses 6879 6899 +20 ☔ View full report in Codecov by Sentry. |
This is an excellent addition. I'm a heavy user of panel_modal, and always wished that it shipped together with panel. Modal windows allow me to save a lot of space in the app. One thing I couldn't get panel_modal to do is to update graphs once they have been created (Tabulator meanwhile updates fine), I hope this development will address it. |
Anything I can help with to get this PR merged? |
Co-authored-by: Philipp Rudiger <[email protected]>
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Fixes #4700
Heavily inspired by https://github.com/awesome-panel/panel-modal. Thank you @MarcSkovMadsen ❤️
screen-recording-2024-08-06_13.32.58.mp4
TO DO:
window as any
.