Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: Return Self for .servable #7530

Merged
merged 3 commits into from
Dec 3, 2024
Merged

type: Return Self for .servable #7530

merged 3 commits into from
Dec 3, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 3, 2024

I noticed this code will confuse the LSP.

import panel as pn

button = pn.widgets.Button().servable()
button.on_click()

Before:
 Screenshot 2024-12-03 15 42 30

After:
 Screenshot 2024-12-03 15 42 14

@hoxbro hoxbro changed the title type: Return Self for .servable type: Return Self for .servable Dec 3, 2024
@hoxbro hoxbro enabled auto-merge (squash) December 3, 2024 14:56
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.21%. Comparing base (7afcc90) to head (7cc71d2).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
panel/template/base.py 0.00% 1 Missing ⚠️
panel/viewable.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7530      +/-   ##
==========================================
- Coverage   82.21%   82.21%   -0.01%     
==========================================
  Files         339      339              
  Lines       51319    51321       +2     
==========================================
  Hits        42193    42193              
- Misses       9126     9128       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit d8587ab into main Dec 3, 2024
18 checks passed
@hoxbro hoxbro deleted the fix_hover_servable branch December 3, 2024 15:26
hoxbro added a commit that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants