Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handling cloudflare #59

Merged
merged 2 commits into from
Aug 1, 2023
Merged

Conversation

abessiari
Copy link
Collaborator

Handling support for Cloudflare. it is optional.

@abessiari abessiari requested review from sierra-moxon and kltm July 31, 2023 20:13
@abessiari
Copy link
Collaborator Author

abessiari commented Jul 31, 2023

@kltm @sierra-moxon

FYI: The handling of Clouldflare is mainly in the the apache proxy image (v6)
The changes are used to capture the real client ip in the apache logs.

GITHUB
https://github.com/geneontology/devops-apache-proxy

DOCKERHUB:
https://hub.docker.com/repository/docker/geneontology/apache-proxy/general

@sierra-moxon
Copy link
Member

Hi @abessiari - I am not sure why this doesn't automatically try and merge in main changes and re-run the tests (I fixed up the tests that have been failing this afternoon). Could you please merge main into your fork and push the changes up so we can confirm that the tests pass again with these changes?

(I also gave you branch permission on this repo, as even with the "Maintainers are allowed to edit this pull request" setting enabled, thank you, I can't see an easy way to force a main branch merge here without forking off your fork).

Copy link
Member

@sierra-moxon sierra-moxon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please merge main in and confirm the tests are passing.

@abessiari
Copy link
Collaborator Author

@sierra-moxon
The tests passed.

@sierra-moxon sierra-moxon merged commit c1d52a0 into geneontology:main Aug 1, 2023
@abessiari abessiari deleted the cloudfront_support branch October 3, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants