fix: tolerate optional fields from external pepr module definitions #1732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1732 +/- ##
=======================================
Coverage 79.71% 79.71%
=======================================
Files 50 50
Lines 2115 2115
Branches 451 460 +9
=======================================
Hits 1686 1686
- Misses 401 427 +26
+ Partials 28 2 -26
|
samayer12
force-pushed
the
1713-helm-custom-labels
branch
from
1e1f9e6 to
eb7b1ce
Compare
samayer12
force-pushed
the
1713-helm-custom-labels
branch
from
293ff8d to
35410f9
Compare
samayer12
changed the title
|
There are some missing tests and execution flows with |
5 tasks
cmwylie19
approved these changes
Jan 29, 2025
|
stronger typing, more concise |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
## Description This PR builds off #1732 to address #1713 ## Related Issue Fixes #1713 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Case Wylie <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR relates to an issue where customLabels were not being applied to a Helm chart after running
pepr build.Related Issue
Relates to #1713
Type of change
Checklist before merging