Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package.json > pepr > customLabels not reflecting in helm chart after build #1713

Closed
btlghrants opened this issue Jan 23, 2025 · 3 comments · Fixed by #1736
Closed

package.json > pepr > customLabels not reflecting in helm chart after build #1713

btlghrants opened this issue Jan 23, 2025 · 3 comments · Fixed by #1736
Assignees
Labels
Bug Something isn't working
Milestone

Comments

@btlghrants
Copy link
Contributor

btlghrants commented Jan 23, 2025

Environment

Device and OS: Dev workstation, Ubuntu 24.04
App version: pepr main
Kubernetes distro being used: n/a
Other: n/a

Steps to reproduce

  1. create a new module with pepr init command
  2. add a `package.json > pepr > customLabels > namespace: { "what": "ever" } config value to your module
  3. run a pepr build

Expected result

Expected that the helm chart output reflects the config'd custom labels in values.yaml > namespace > labels.

Actual Result

Helm chart output reflects the default custom labels in values.yaml > namespace > labels.

Visual Proof (screenshots, videos, text, etc)

n/a

Severity/Priority

dunno

Additional Context

I left a test demonstrating existing vs desired behavior in the (upcoming) integration/cli/build.configequality.test.ts.

@btlghrants btlghrants added this to the v0.44.0 milestone Jan 23, 2025
@btlghrants btlghrants moved this from 🆕 New to 📋 Backlog in Pepr Project Board Jan 23, 2025
@cmwylie19 cmwylie19 moved this from 📋 Backlog to 🏗 In progress in Pepr Project Board Jan 23, 2025
@cmwylie19 cmwylie19 modified the milestones: v0.44.0, v0.45.0 Jan 24, 2025
@samayer12
Copy link
Contributor

Local troubleshooting (i.e., with 0.0.0-development) must also point to a development version of pepr in the module's package.json. Something along the lines of file://some/path/pepr-0.0.0-development.tgz.

Tests against published versions of pepr don't have this concern.

@samayer12 samayer12 added the Bug Something isn't working label Jan 27, 2025
@samayer12
Copy link
Contributor

Issue confirmed, looking into the cause

@samayer12
Copy link
Contributor

May have found the root cause in overridesFile.ts. Will have to investigate further & make tests pass. See #1732 for implementation details.

github-merge-queue bot pushed a commit that referenced this issue Jan 30, 2025
## Description

This PR builds off #1732 to address #1713 

## Related Issue

Fixes #1713

## Type of change

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Other (security config, docs update, etc)

## Checklist before merging
- [ ] Unit,
[Journey](https://github.com/defenseunicorns/pepr/tree/main/journey),
[E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples),
[docs](https://github.com/defenseunicorns/pepr/tree/main/docs),
[adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or
updated as needed
- [x] [Contributor Guide
Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request)
followed

---------

Co-authored-by: Case Wylie <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Pepr Project Board Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants