-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
package.json > pepr > customLabels not reflecting in helm chart after build #1713
Comments
Local troubleshooting (i.e., with Tests against published versions of pepr don't have this concern. |
Issue confirmed, looking into the cause |
May have found the root cause in overridesFile.ts. Will have to investigate further & make tests pass. See #1732 for implementation details. |
## Description This PR builds off #1732 to address #1713 ## Related Issue Fixes #1713 ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Unit, [Journey](https://github.com/defenseunicorns/pepr/tree/main/journey), [E2E Tests](https://github.com/defenseunicorns/pepr-excellent-examples), [docs](https://github.com/defenseunicorns/pepr/tree/main/docs), [adr](https://github.com/defenseunicorns/pepr/tree/main/adr) added or updated as needed - [x] [Contributor Guide Steps](https://docs.pepr.dev/main/contribute/#submitting-a-pull-request) followed --------- Co-authored-by: Case Wylie <[email protected]>
Environment
Device and OS: Dev workstation, Ubuntu 24.04
App version: pepr main
Kubernetes distro being used: n/a
Other: n/a
Steps to reproduce
pepr init
commandpepr build
Expected result
Expected that the helm chart output reflects the config'd custom labels in
values.yaml > namespace > labels
.Actual Result
Helm chart output reflects the default custom labels in
values.yaml > namespace > labels
.Visual Proof (screenshots, videos, text, etc)
n/a
Severity/Priority
dunno
Additional Context
I left a test demonstrating existing vs desired behavior in the (upcoming)
integration/cli/build.configequality.test.ts
.The text was updated successfully, but these errors were encountered: