Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure middleware #1434

Merged
merged 1 commit into from
Jul 30, 2019
Merged

Configure middleware #1434

merged 1 commit into from
Jul 30, 2019

Conversation

nikku
Copy link
Member

@nikku nikku commented Jul 23, 2019

Implements a generic configuration middleware as discussed in #1374.

@nikku nikku requested a review from pinussilvestrus July 23, 2019 14:12
@bpmn-io-tasks bpmn-io-tasks bot added the needs review Review pending label Jul 23, 2019
@nikku nikku force-pushed the configure-middleware branch from d06553c to e6a2abd Compare July 23, 2019 14:12
@nikku nikku mentioned this pull request Jul 23, 2019
Closed
@pinussilvestrus pinussilvestrus mentioned this pull request Jul 23, 2019
Merged
@nikku nikku mentioned this pull request Jul 25, 2019
Closed
4 tasks
@nikku nikku requested a review from philippfromme July 30, 2019 08:13
@nikku
feat(BpmnModeler): add generic extension point
034b323 
This adds the bpmn.modeler.configure extension point.

The extension point allows users to provide a middleware
options => newOptions that can be used to apply
arbitrary configuration updates before the editor gets
created.

This also builds existing entry points onto the new pattern
and adds a distinct utility to carry out the configuration.

Supersedes #1374
@nikku nikku force-pushed the configure-middleware branch from e6a2abd to 034b323 Compare July 30, 2019 14:12
philippfromme
philippfromme reviewed Jul 30, 2019
View reviewed changes
client/src/app/tabs/bpmn/util/__tests__/configureSpec.js
describe('should collect warnings', function() {

it('bpmn.modeler.moddleExtension', function() {
// given
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line break. 🤣

philippfromme
philippfromme reviewed Jul 30, 2019
View reviewed changes
client/src/app/tabs/bpmn/util/__tests__/configureSpec.js


it('bpmn.modeler.configure', function() {
// given
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing line 🥛 🔨 .

@nikku
Copy link
Member Author

nikku commented Jul 30, 2019

Any other concerns? 🎺 🍰 ❔

philippfromme
philippfromme approved these changes Jul 30, 2019
View reviewed changes
Copy link
Contributor

@philippfromme philippfromme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍰

@merge-me merge-me bot merged commit 5dcc968 into develop Jul 30, 2019
@bpmn-io-tasks bpmn-io-tasks bot removed the needs review Review pending label Jul 30, 2019
@delete-merged-branch delete-merged-branch bot deleted the configure-middleware branch July 30, 2019 14:46
@nikku nikku added this to the M30 milestone Jul 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippfromme philippfromme philippfromme approved these changes

@pinussilvestrus pinussilvestrus Awaiting requested review from pinussilvestrus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
M30
Development

Successfully merging this pull request may close these issues.
2 participants
@nikku @philippfromme