-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(client/BpmnEditor): allow passing linting configurations via plugin #1374
Conversation
@pinussilvestrus Let's have a quick chat regarding this tomorrow. I'll meet you in our favorite chat tool. |
👍 I'll create an appointment for this (+ Chat invitation) |
Let's not merge this as is but consider a way how to create a generic extension point for the BPMN editor (and the others). The idea would be that a plugin is simply a function of SKETCH:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a proper generic extension point instead (cf. this comment).
This adds the bpmn.modeler.configure extension point. The extension point allows users to provide a middleware options => newOptions that can be used to apply arbitrary configuration updates before the editor gets created. This also builds existing entry points onto the new pattern and adds a distinct utility to carry out the configuration. Supersedes #1374
This adds the bpmn.modeler.configure extension point. The extension point allows users to provide a middleware options => newOptions that can be used to apply arbitrary configuration updates before the editor gets created. This also builds existing entry points onto the new pattern and adds a distinct utility to carry out the configuration. Supersedes #1374
Closing in favor of #1434. |
This adds the bpmn.modeler.configure extension point. The extension point allows users to provide a middleware options => newOptions that can be used to apply arbitrary configuration updates before the editor gets created. This also builds existing entry points onto the new pattern and adds a distinct utility to carry out the configuration. Supersedes #1374
This adds the bpmn.modeler.configure extension point. The extension point allows users to provide a middleware options => newOptions that can be used to apply arbitrary configuration updates before the editor gets created. This also builds existing entry points onto the new pattern and adds a distinct utility to carry out the configuration. Supersedes #1374
This allows parsing linting configuration to the Camunda Modeler.
Reference: https://github.com/bpmn-io/bpmn-js-bpmnlint#usage
Related by camunda/camunda-modeler-linter-plugin#5