This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Removing Generate*() methods. #321
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
| public TagHelperOutput( | ||
| string tagName, | ||
| [NotNull] IDictionary<string, string> attributes, | ||
| [NotNull] IHtmlEncoder htmlEncoder) |
There was a problem hiding this comment.
Ahhh awesome no longer need this.
You should also remove this: https://github.com/aspnet/Razor/blob/dev/src/Microsoft.AspNet.Razor.Runtime/project.json#L9
|
⌚ |
|
⌚ only for the config changes. |
added 2 commits
March 16, 2015 08:04
|
Addressed comments. |
| RenderTagOutput(_tagHelperContext.OutputGenerateEndTagMethodName, methodReturnsString: true); | ||
|
|
||
| RenderStartWriteTagHelperMethod(); | ||
| _writer.Write(ExecutionContextVariableName).WriteEndMethodInvocation(); |
There was a problem hiding this comment.
nit: couldn't this be done inside RenderStartWriteTagHelperMethod(), perhaps after renaming that method to (say) RenderWriteTagHelperMethodCall?
|
⌚ please grab me when you have updated the new doc comments |
|
Updated.. |
|
|
||
| _writer.Write(ExecutionContextVariableName) | ||
| .WriteEndMethodInvocation(endLine: false) | ||
| .WriteLine(".Wait();"); |
There was a problem hiding this comment.
teensy nit: here's where my commit comment lands. you're indenting the easy and easy-to-maintain way just above (line 366) but doing it the hard way here.
|
|
|
|
|
Checked in. Thanks! 7daec14 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#318