You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Dec 19, 2018. It is now read-only.
for future consideration (not this PR) but related to the TagHelperContent / DefaultTagHelperContent split introduced here: suggest we split TagHelperOutput along similar lines and get the Generate*() methods and perhaps ContentSet out of tag helper authors' faces.
This split could go further and move the Generate*() methods completely out of this class (or class hierarchy). if _isTagNameNullOrWhitespace were exposed as a property (like ContentSet), these methods would not require any private information. could move generation many places but I suggest the RazorPage.WriteLiteral[To]([TextWriter,] TagHelperExecutionContext) methods I proposed elsewhere. in any case, this would pull apart the mix of responsibilities TagHelperOutput has today.
The text was updated successfully, but these errors were encountered:
the general point is to revisit what we expose in TagHelperContent and how we use that class in the framework. this includes looking closely at the boilerplate code generated for tag helper scenarios.
not necessarily a part of this PR: suggest we create WriteLiteral(TagHelperExecutionContext) and WriteLiteralTo(TextWriter, TagHelperExecutionContext) overloads in RazorPage. no reason to generate the boilerplate code from WriteLiteral(__tagHelperExecutionContext.Output.GenerateStartTag()); through this line. possible to include the RunAsync() call in the methods but that doesn't fit well into a "WriteSomething()` method.
Quoting @dougbu 's comment:
for future consideration (not this PR) but related to the
TagHelperContent / DefaultTagHelperContent
split introduced here: suggest we splitTagHelperOutput
along similar lines and get theGenerate*()
methods and perhapsContentSet
out of tag helper authors' faces.This split could go further and move the
Generate*()
methods completely out of this class (or class hierarchy). if_isTagNameNullOrWhitespace
were exposed as a property (likeContentSet
), these methods would not require any private information. could move generation many places but I suggest theRazorPage.WriteLiteral[To]([TextWriter,] TagHelperExecutionContext)
methods I proposed elsewhere. in any case, this would pull apart the mix of responsibilitiesTagHelperOutput
has today.The text was updated successfully, but these errors were encountered: