This repository was archived by the owner on Dec 19, 2018. It is now read-only.
Made IntermediateNodeWalker.Ancestors indexable #1526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rynowak
reviewed
Jul 7, 2017
|
|
||
| protected IEnumerable<IntermediateNode> Ancestors => _ancestors; |
There was a problem hiding this comment.
There is already a unit test that verifies if the ancestors are set correctly. Did you mean add one that tests indexability?
There was a problem hiding this comment.
Does it verify the iteration order? If it does then consider me signed off.
There was a problem hiding this comment.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1510
@rynowak @NTaylorMullen